Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save modifications on config/.env #127

Open
petitminion opened this issue Jan 9, 2021 · 7 comments
Open

Save modifications on config/.env #127

petitminion opened this issue Jan 9, 2021 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@petitminion
Copy link

Hello,

Regularly the changes I do to config/.env file are deleted ans restored to default. My server upgrade automatically so it may be that.. How can I change setting persistently ?

thx !

@yalh76
Copy link
Member

yalh76 commented May 19, 2021

with last version of the package, .env is still restored to default but you will find in the upgrade logs all the modification made on your previous .env.
It to be sure your funkwhale has a good .env

@yalh76 yalh76 closed this as completed May 19, 2021
@matthias4217
Copy link

matthias4217 commented Mar 27, 2022

Could we have an option to do otherwise ? I'm hosting my music on an external storage, and would prefer to be able to have it set permanently. I understand Yunohost apps are made to be easy to install, but being able to adjust settings is valuable.

One solution I can see (which might not be a good solution) would be to have a .custom.env, with all the user config, which would not be overwritten, and a .default.env, with the stable config. During upgrades, I think we could simply do a

cat .default.env > .env
cat .custom.env >> .env

I understand this means taking the risk of an upgrade failing because of a bad user-made .env, so maybe this solution does not fit the Yunohost philosophy. Alternatively, being able to set some settings (external S3 storage for instance) during the installation or after could be nice, but this would probably lead to the same issue.

Anyway, this app works fine as it is, so thank you for your work !

@yalh76 yalh76 reopened this Mar 28, 2022
@yalh76
Copy link
Member

yalh76 commented Mar 28, 2022

The solution would be to integrate a config panel: https://yunohost.org/en/packaging_apps_config_panel

If someone want to do a PR ;)

@yalh76 yalh76 added the help wanted Extra attention is needed label Mar 28, 2022
@Thovi98
Copy link
Member

Thovi98 commented Jun 12, 2023

What are the specific modifications of the .env file you want to keep?

@matthias4217
Copy link

I’d like to use object storage. There may be other interesting options too, but I don’t remember the possibilities well enough.

@Thovi98
Copy link
Member

Thovi98 commented Jun 12, 2023

Okay I don’t really understand what’s object storage to be honest. So I don’t think I will be able to help here…

@benborges
Copy link

Okay I don’t really understand what’s object storage to be honest. So I don’t think I will be able to help here…

In the context of Funkwhale, Object Storage relate to the env part that is used to configure an external storage, such as S3 or Minio to store the music files. it's a bit of a must-have for Funkwhale/Yunohost since MP3/Flac/MP4 can take a lot of space, so it's better to externalize it in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants