Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various hooks inconsistencies results in mis-synchonization between freshrss accounts and who should exactly have access according to yunohost's permission #124

Open
alexAubin opened this issue Aug 14, 2021 · 2 comments

Comments

@alexAubin
Copy link
Member

The post_user_create hook is called after each user creation, even if the corresponding freshrss.main permission is not allowed for all_users

Additionally, if the admin tweaks permission, the hook post_app_addaccess may be called and attempt to create an already-existing account.

AND if the permission gets removed, there's no post_remove_access to remove the account

Not sure what we want exactly .... I think we should either have (post_user_create, post_user_delete), OR (post_app_addaccess, post_app_removeaccess), but we should probably not have all 3 or 4 hooks...

@alexAubin alexAubin added the bug label Aug 14, 2021
@lapineige
Copy link
Member

lapineige commented Aug 28, 2021

#123 should (partly) fix that.

@lapineige
Copy link
Member

Any recommendation for packaging v2 migration on that point ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants