Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running against keyring-25 #612

Closed
mkszuba opened this issue Apr 26, 2024 · 1 comment
Closed

Allow running against keyring-25 #612

mkszuba opened this issue Apr 26, 2024 · 1 comment

Comments

@mkszuba
Copy link

mkszuba commented Apr 26, 2024

  • YubiKey Manager (ykman) version: 5.4.0
  • How was it installed?: with pip in a venv
  • Operating system and version: Gentoo Linux, up-to-date rolling release
  • YubiKey model and version: YubiKey 5 NFC (5.4.3)
  • Bug description summary:

At the moment, i.e. up to and including the current state of the main Git branch, yubikey-manager depends on keyring < 25. However, running the 5.4.0 test suite - including integration tests against a dedicated YK5 - produces no errors against keyring-25.1.0 (i.e. the latest version currently available from PyPI), and I have yet to observe any run-time errors of this configuration. I would therefore like to suggest removing this version cap.

Steps to reproduce

  • Download yubikey-manager sources
  • Edit pyproject.toml so that it no longer requires using an older version of keyring
  • Install yubikey-manager using the modified source tree
  • Run the test suite

Expected result

yubikey-manager pulls keyring-25, installs fine, passes all tests and produces no run-time errors during normal use.

Actual results and logs

yubikey-manager pulls keyring-24.3.1.

Other info

The aforementioned testing has been conducted against a py3.11 venv configured not to use system site-packages.

@dainnilsson
Copy link
Member

This is resolved in the latest version (5.5.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants