-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ykman fido access change-pin - Does not return result #577
Comments
Not sure if I should create a new "Issue" but I also found the same for |
There are different schools of thought on this, each with pros and cons. Traditionally a UNIX command line tool does not output anything on success, which is generally useful when scripting. On the other hand, not giving the user any feedback here can be confusing. That said, the tool currently isn't consistent in either approach (output info on success, or only on failure) which is clearly not desirable, and should be changed. We should evaluate which approach to take, and then implement it consistently across the different commands. |
@dainnilsson I agree. Inconsistency breads uncertainty. Perhaps the use of the |
After some additional though on this we determined that having output for all successful commands would be more helpful than not. We've now released 5.5.0, and as part of that release we have added output to commands which did not already produce output. The exception to this is when a command outputs a file and the user chooses to redirect that file to stdout. Hopefully this resolves the issue. If you find any command which still do not produce any output, please let us know by opening a new issue. |
ykman fido access change-pin
does not return resultSteps to reproduce
ykman fido access change-pin
Expected result
I expect a dialog that says something like "
FIDO password updated
" similar if you run the following command:ykman oath access change
Actual results and logs
There is no output for a confirmation that the change has worked.
There is an output if there is an error. For example, if you enter the wrong confirmation password you get the following:
Error: The two entered values do not match. Enter your new PIN:
Therefore you are questioning if the command ran correctly or not, and can only know by testing FIDO with your new password.
Other info
None
The text was updated successfully, but these errors were encountered: