Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore YubiHSM when enumerating USB devices #289

Merged
merged 3 commits into from
Dec 2, 2019
Merged

Ignore YubiHSM when enumerating USB devices #289

merged 3 commits into from
Dec 2, 2019

Conversation

emlun
Copy link
Member

@emlun emlun commented Dec 2, 2019

Fixes #288.

@emlun emlun added the bug label Dec 2, 2019
@emlun emlun self-assigned this Dec 2, 2019
@dainnilsson
Copy link
Member

Not sure I think we should be detecting the YubiHSM here, what happens if we add another Product later on? We'll have the same problem then. Isn't it better to catch the ValueError and always return None in that case?

@emlun emlun merged commit 0906d11 into master Dec 2, 2019
@emlun emlun deleted the ignore-yubihsm branch December 2, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dainnilsson dainnilsson dainnilsson approved these changes

@fdennis fdennis fdennis approved these changes

Assignees

@emlun emlun

Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YubiHSM causes (harmless) ValueError: Invalid PID
3 participants
@emlun @dainnilsson @fdennis