Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOIR support #5

Closed
YorVeX opened this issue May 14, 2023 · 1 comment · Fixed by #15
Closed

QOIR support #5

YorVeX opened this issue May 14, 2023 · 1 comment · Fixed by #15
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@YorVeX
Copy link
Owner

YorVeX commented May 14, 2023

QOIR is a derivate of QOI that has both improved compression speed and ratio compared to QOI. That pretty much sounds like a "can only win" situation, however, the one nice thing about QOI is that it's so simple and Beam has a pure C# implementation for it that will always automatically be platform independent, without the need for any external library.

For QOIR the code is much more complex, not really making me want to rewrite it as a full C# implementation, so it will be yet another native library that has to be separately managed and installed and so on. Right now I think the managed QOI implementation will stay in Beam in addition as an always available fallback option even when QOIR support was added.

@YorVeX YorVeX added the enhancement New feature or request label May 14, 2023
@YorVeX
Copy link
Owner Author

YorVeX commented Jun 15, 2023

PoC can already be deemed successful, even with optimizations not being finished yet (e.g. lots of unnecessary memory allocations) the QOIR compression is already causing 5% less CPU load than QOI in my test setup on average while having a 5% better compression ratio, only wins exactly as I was hoping.

Next steps are to offer this as a configurable option in the GUI and of course to improve the memory allocations.

@YorVeX YorVeX self-assigned this Jun 15, 2023
@YorVeX YorVeX linked a pull request Jun 17, 2023 that will close this issue
@YorVeX YorVeX added this to the v1.0 release milestone Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant