Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply rename in the Indexable model #135

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Apply rename in the Indexable model #135

wants to merge 1 commit into from

Conversation

diedexx
Copy link
Member

@diedexx diedexx commented Dec 6, 2021

Summary

This PR can be summarized in the following changelog entry:

  • Show Indexable columns that were added/renamed in Yoast SEO Free 17.9 in the query monitor output.

Relevant technical choices:

  • N/A

Milestone

  • I've attached the next release's milestone to this pull request.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Enable both the Query Monitor plugin and this branch of the test helper.
  • Checkout the branch for this PR on Yoast SEO Free (or use latest trunk if it's already merged)
  • View a post on your site.
  • Click the query monitor bar.
    image
  • Open the "Yoast SEO" section in the query monitor window.
  • Find the number_of_publicly_viewable_posts and is_publicly_viewable columns.
    Pasted_Image_06_12_2021__10_21

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

@diedexx diedexx added this to the 1.16 milestone Dec 6, 2021
@diedexx diedexx changed the title Apply renamed in the Indexable model Apply rename in the Indexable model Dec 6, 2021
@diedexx diedexx mentioned this pull request Dec 6, 2021
Open
7 tasks
@leonidasmi leonidasmi self-requested a review December 6, 2021 14:52
leonidasmi
leonidasmi approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@leonidasmi leonidasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 👍

@diedexx diedexx modified the milestones: 1.16, Indexable Sitemap Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonidasmi leonidasmi leonidasmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Indexable Sitemap
Development

Successfully merging this pull request may close these issues.
2 participants
@diedexx @leonidasmi