Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade fstream and tar #49

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Upgrade fstream and tar #49

merged 1 commit into from
Jun 5, 2019

Conversation

IreneStr
Copy link
Contributor

@IreneStr IreneStr commented Jun 4, 2019

Upgrades tar to 2.2.2 and fstream to 1.0.12.

Relevant technical choices:

I ran yarn upgrade grunt-contrib-compress. Because there was no newer version, it updated grunt-contrib-compress's dependencies and dependecies of dependencies. Fstream and tar were two of them.

Test instructions

This PR can be tested by following these steps:

  • Run grunt artifact and see no errors.
  • Upload the artifact.zip as a plugin to your local installation.
  • Activate the plugin and see that it works.

Fixes #47
Fixes #48

@igorschoester
Copy link
Member

Acceptance ✅

@igorschoester igorschoester merged commit 841f8a0 into develop Jun 5, 2019
@igorschoester igorschoester deleted the 47-48-update-tar-and-fstream branch June 5, 2019 08:58
@igorschoester igorschoester added this to the Next release milestone Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

Upgrade fstream to version 1.0.12 or later Upgrade tar to version 2.2.2 or later
2 participants
@IreneStr @igorschoester