Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema filters #37

Merged
merged 4 commits into from
Apr 30, 2019
Merged

Add schema filters #37

merged 4 commits into from
Apr 30, 2019

Conversation

igorschoester
Copy link
Member

Summary

This PR can be summarized in the following changelog entry:

  • Added filters for the Breadcrumb and WebPage Graphs.

Relevant technical choices:

  • Added selection creation helper.
  • 3 choices: Don't influence, Always include and Never include.

Test instructions

This PR can be tested by following these steps:

  • Switch to this branch.
  • Activate the plugin in WP.
  • Go to the Tools -> Yoast Test page.

is_needed

  • Go to a WP output post/page/whatever, open the source and copy the JSON+LD script.
  • Use Google's SDTT to test the stitching.
  • Try different values and check if the schema output matches.
    • Don't influence should result in the same output as without the plugin installed.
    • Always include is a bit harder to verify with some options. But you can go to SEO -> Search Appearance -> Breadcrumbs and disable the breadcrumbs output. Note this is now not stitched anymore due to not being linked in the webpage.
    • Never include will also result in strange stitch situations.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #35

@abotteram
Copy link
Contributor

Acceptance 👍

@abotteram
Copy link
Contributor

CR 👍

@abotteram abotteram added this to the 1.1 milestone Apr 30, 2019
@abotteram abotteram merged commit 4a15041 into develop Apr 30, 2019
@abotteram abotteram deleted the 35-add-schema-filters branch April 30, 2019 11:51
@igorschoester igorschoester mentioned this pull request May 2, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add schema filters for testing purposes
2 participants