Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkbox to switch to the AI staging api #195

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

enricobattocchi
Copy link
Member

@enricobattocchi enricobattocchi commented Aug 9, 2023

Summary

This PR can be summarized in the following changelog entry:

  • Adds a checkbox to use the AI staging API.

Relevant technical choices:

  • I've added the checkbox in the "Enable development mode" section, which I renamed "Development settings" since the sections are already a lot and sometimes too fine-grained.
  • We have opted to not bust the usermeta settings about the API token for now, since after chaning the setting it would need to happen for all the users in a site. This means that the first request after switching from production to staging or vice versa will fail and then after the code generates a new token it will work again.
    This results in 1 try again needed after every switch.

Milestone

  • I've attached the next release's milestone to this pull request.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Install with Premium containing this PR and check that the AI feature works with and without the checkbox ticked.
    note that there is no way to check in the plugin which URL is actually used so we are basically performing a regression test.

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Fixes #194

@enricobattocchi enricobattocchi added this to the 1.18 milestone Aug 9, 2023
@enricobattocchi enricobattocchi changed the base branch from develop to release/1.18 August 9, 2023 10:03
Copy link
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + ACC 👍

@thijsoo thijsoo merged commit 83f8b4d into release/1.18 Aug 9, 2023
7 checks passed
@thijsoo thijsoo deleted the add-control-ai-staging-api branch August 9, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Helper: add a control to switch to the AI staging API
2 participants