Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absolute path is not being created when attachment already has absolute path #9682

Closed
moorscode opened this issue May 9, 2018 · 1 comment
Closed

Absolute path is not being created when attachment already has absolute path #9682

moorscode opened this issue May 9, 2018 · 1 comment
Assignees
@jcomack
Milestone
7.5

Comments

@moorscode
Copy link
Contributor

During the OpenGraph image functionality, we started to check for image filesize.
This check is being done with filesize, which requires an absolute path to check against.

The method we currently have always adds the basedir to the path, even if it already contains it.
@moorscode moorscode added this to the 7.5 milestone May 9, 2018
@moorscode moorscode mentioned this issue May 9, 2018
Merged
2 tasks
@andizer andizer self-assigned this May 9, 2018
@andizer andizer assigned moorscode and unassigned andizer May 9, 2018
@andizer andizer assigned andizer and unassigned moorscode May 9, 2018
@andizer andizer removed their assignment May 9, 2018
@Pcosta88
Copy link
Contributor

Pcosta88 commented May 9, 2018

Please inform the customer of conversation # 361143 when this conversation has been closed.

@jcomack jcomack self-assigned this May 10, 2018
@jcomack jcomack closed this as completed May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcomack jcomack

Labels
None yet
Projects
None yet
Milestone
7.5
Development

No branches or pull requests
4 participants
@andizer @moorscode @jcomack @Pcosta88