Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter card size setting is broken #7719

Open
hedgefield opened this issue Aug 17, 2017 · 10 comments
Open

Twitter card size setting is broken #7719

hedgefield opened this issue Aug 17, 2017 · 10 comments

Comments

@hedgefield
Copy link
Contributor

In the plugin settings you can choose whether you want to use the small or large twitter card, but this setting is useless.

  • When you have no image specified for twitter, it displays the blank small card.

window

  • When you DO have an image specified, it always displays the large card, no matter the setting. And what's more, the image is displayed square, while the twitter card has rounded edges.

window

I expect it to use the format I chose, and at least have the blank and filled formats be consistent with each other.

@jdevalk
Copy link
Contributor

jdevalk commented Aug 22, 2017

@PatrickYoast @jcomack could you look into this and specify what we should be doing?

@jdevalk jdevalk removed the backlog label Aug 22, 2017
@hedgefield
Copy link
Contributor Author

Is being investigated in https://github.com/Yoast/roadmap/issues/24

@PatrickYoast
Copy link

PatrickYoast commented Sep 25, 2017

@hedgefield Can you still reproduce this?

When I switch the setting between Summary and Summary with a large image on my live test site and run it through the Twitter card validator it works as expected

Summary
card_validator___twitter_developers_2

Summary with a large image
card_validator___twitter_developers

@hedgefield
Copy link
Contributor Author

Sorry, I should have specified: I mean the preview card we show in our metabox in WP. Changing the setting doesn't have any effect on that.

@PatrickYoast
Copy link

PatrickYoast commented Sep 25, 2017

Good to know!

In that case, I do agree that we need to show a preview that's as closely related to the end result as possible. Whether that's a Summary or a Summary with a large image our preview should adjust accordingly.

@jdevalk
Copy link
Contributor

jdevalk commented Sep 25, 2017

SO technically this isn't a bug, but an enhancement. At the same time, it's worth queueing.

@jdevalk
Copy link
Contributor

jdevalk commented Sep 25, 2017

Could you add this to the roadmap @omarreiss ?

@omarreiss
Copy link
Contributor

@hedgefield
Copy link
Contributor Author

It's a bug in the sense that it always shows the small card when no info has been entered and always shows the large card when you do have something filled in for the social preview/meta description, even though both templates exist and we have a setting to switch between them 🙃

@jcomack
Copy link
Contributor

jcomack commented Sep 26, 2017

Just to clarify: Basically, the last iteration of the Social Previews automatically detected the image size and changed the preview accordingly. The setting in the backend was never included in this check and therefore the preview could be considered broken.

It might be a good idea to see what Twitter does if that option is omitted from the meta tags and possibly add some kind of "Auto-detect" option as well, depending on the result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants