Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for WPVIP: Never use extract #7704

Open
moorscode opened this issue Aug 16, 2017 · 0 comments
Open

Prepare for WPVIP: Never use extract #7704

moorscode opened this issue Aug 16, 2017 · 0 comments

Comments

@moorscode
Copy link
Contributor

WordPress VIP is not accepting any extract function calls.
We are using these in some generalized template filling.

Ideally we will remove these while converting the views to React.
Depending on the severity and the speed of the React team implementing the view, we might need to refactor how the arguments are being passed to the includes.

See: https://vip.wordpress.com/documentation/code-review-what-we-look-for/#using-extract

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants