Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for WPVIP: Use VIP activation procedure #7702

Open
moorscode opened this issue Aug 16, 2017 · 2 comments
Open

Prepare for WPVIP: Use VIP activation procedure #7702

moorscode opened this issue Aug 16, 2017 · 2 comments

Comments

@moorscode
Copy link
Contributor

register_activation_hook and register_deactivation_hook are not supported because of the way plugins are loaded on WordPress VIP using wpcom_vip_load_plugin.

See: https://vip.wordpress.com/documentation/code-review-what-we-look-for/#plugin-registration-hooks

The documentation is not clear on how to implement a way that will work.
This should be determined.

Probably abundant but: note that these hooks must still remain to work for non-VIP installations.

@moorscode moorscode changed the title Prepare for WPVIP: allow the use of Prepare for WPVIP: Use VIP activation procedure Aug 16, 2017
@ashley-hebler
Copy link

ashley-hebler commented Feb 7, 2018

Hey @moorscode. I work for a company who hosts sites on VIP. We're always getting requests for adding Yoast to our writers' toolset. Any idea when this would be available as a VIP approved plugin? We'd love to use it in our theme! Is it just waiting on a PR fixing some of the compliance needs?

@bschneidewind
Copy link

Any updates on this one?

I've been using wpcom_vip_load_plugin( 'wordpress-seo/wp-seo.php' ); with mixed success... works on one site, but not on another VIP Go site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants