Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Editor Tool - Buttons now contain <code>robots.txt</code> #7078

Closed
garretthyder opened this issue May 4, 2017 · 4 comments
Closed

File Editor Tool - Buttons now contain <code>robots.txt</code> #7078

garretthyder opened this issue May 4, 2017 · 4 comments

Comments

@garretthyder
Copy link
Contributor

garretthyder commented May 4, 2017

What did you expect to happen?

The buttons shouldn't have the <code></code> portion in their text.

What happened instead?

screen shot 2017-05-04 at 2 31 05 pm

How can we reproduce this behavior?

Go to the File Editor Tool and look at the buttons.

Can you provide a link to a page which shows this issue?

yourdomain.com/wp-admin/admin.php?page=wpseo_tools&tool=file-editor

Technical info

  • WordPress version: 4.7.4
  • Yoast SEO version: 4.7
@CarolineGeven
Copy link
Contributor

Thanks for reporting this issue. It seems that this has gone wrong in the translations. Which locale (language) are you using?

@garretthyder
Copy link
Contributor Author

garretthyder commented May 8, 2017

Hi @CarolineGeven
You're right, it's definitely a translation issue. Seems to be quite pervasive in en_GB (English (UK));
screen shot 2017-05-08 at 9 33 49 am
Example - https://translate.wordpress.org/projects/wp-plugins/wordpress-seo/dev/en-gb/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=632276&filters%5Btranslation_id%5D=23544125

You might want to get your en_GB validator to go through the entire translation base to remove all the <code>, here's a link to a search for it on dev trunk;
https://translate.wordpress.org/projects/wp-plugins/wordpress-seo/dev/en-gb/default?filters%5Bterm%5D=%3Ccode%3E&filters%5Buser_login%5D=&filters%5Bstatus%5D=either&filter=Filter&sort%5Bby%5D=priority&sort%5Bhow%5D=desc

All the best,
Cheers

@Djennez
Copy link
Member

Djennez commented Jan 22, 2019

These translations seem to have since been fixed, based on what I can find in the translation files. I will close this issue, but if you are able to locate any other related issues, please do let us know.

@garretthyder
Copy link
Contributor Author

Thanks @Djennez it appears to be good now. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants