Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbiage Cleanup: Please revisit verbiage on Pinterest tab #6944

Closed
garretthyder opened this issue Apr 5, 2017 · 3 comments
Closed

Verbiage Cleanup: Please revisit verbiage on Pinterest tab #6944

garretthyder opened this issue Apr 5, 2017 · 3 comments

Comments

@garretthyder
Copy link
Contributor

Hello,

I just wanted to point out the confusing verbiage on the Pinterest Settings tab;
screen shot 2017-04-05 at 3 52 12 pm

Specifically this line;

To confirm your site with Pinterest, add the meta tag here:

This is confusing in that if you place the full meta tag (<meta name=“p:domain_verify” content=“d7afd0e361b04474a5e54308b7471e26"/>) then it won't work cause it'll do an inception thingy of placing the meta-tag within a meta tag.

In actuality what they want to place in that field is the unique key/id from the content attribute on the Pinterest Meta tag.
So from this - <meta name=“p:domain_verify” content=“d7afd0e361b04474a5e54308b7471e26"/>
We want this - d7afd0e361b04474a5e54308b7471e26

Might be as simple as changing text to say;

To confirm your site with Pinterest, add the key from your meta tag here:

Thank you

@thulshof
Copy link
Contributor

thulshof commented Apr 6, 2017

Thanks for your suggestion! Sounds like something we should seriously consider. We'll discuss this internally. Any progress or decisions can be followed in this issue.

@jdevalk
Copy link
Contributor

jdevalk commented Mar 13, 2018

This actually sounds like a bug. This test string:

<meta name="p:domain_verify" content="d7afd0e361b04474a5e54308b7471e26"/>

Is actually parsed properly, after which d7afd0e361b04474a5e54308b7471e26 is stored.

The example @garrett-eclipse gave in the issue has other quotes, which is why it fails, but they're not proper HTML quotes. So... Please reopen if I'm wrong, but I think I'm not :)

@jdevalk jdevalk closed this as completed Mar 13, 2018
@jdevalk jdevalk removed the backlog label Mar 13, 2018
@garretthyder
Copy link
Contributor Author

Thanks @jdevalk you're not wrong at all. I never assumed you could put the whole meta tag in there and it would extract what it needed. So that's my bad. Just tested and works great, and here I was thinking i had to pull the codes out of all those meta fields. Eyes have been opened :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants