Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a language chooser to the metabox #5737

Open
terw-dan opened this issue Sep 28, 2016 · 3 comments
Open

Add a language chooser to the metabox #5737

terw-dan opened this issue Sep 28, 2016 · 3 comments

Comments

@terw-dan
Copy link
Member

Since we are supporting more and more languages for the readability scores, I think it would be a good idea to add a language chooser to the metabox.

Currently we assume the language of the admin is the same language the post is written in, but this doesn't have to be true. It probably will be for most users, but an option to override this would be useful.

We only need it for the readability tab, since this is language dependent. It could look something like this
image

In stead of using the current locale from the admin and pushing that to the paper, we can use the value from the dropdown to set in the paper. So updating the value from the select box should put that in the paper, and we could save this per post in the database, so you don't have to set it every time you create a new post.

We could even make a setting in the Yoast SEO settings to put a default language in for posts if this is desired.

@terw-dan terw-dan added this to the Future release milestone Sep 28, 2016
@afercia
Copy link
Contributor

afercia commented Sep 28, 2016

Related: this new WP feature that will probably land in 4.7:
https://core.trac.wordpress.org/ticket/29783

@moorscode
Copy link
Contributor

Having a user language helps to facilitate a more specific need to have language experts on the site. Although a single user can also write in multiple languages.

When user [A] with language [1] selected visits a post of user [B] with language [2] you still want to have the checks set for the language the document is initially written in.

This is also a good indicator for the language tag on the front-end itself.

The placement of the language selection might be a discussion point on itself, because it is a "document" setting and not a "readability" or keyword specific thing. Thus it might even belong in WordPress core in page meta.

@moorscode moorscode removed this from the Future release milestone Sep 28, 2016
@atimmer
Copy link
Contributor

atimmer commented Nov 10, 2016

Related #6053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants