-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a check for big base64 images #20318
Comments
Comment from Hanna Worku: Would this work as a new condition the the Images assessment? |
Please inform the customer of conversation # 1010926 when this conversation has been closed. |
Please inform the customer of conversation # 1031752 when this conversation has been closed. |
Please inform the customer of conversation # 1049204 when this conversation has been closed. |
Please inform the customer of conversation # 1058610 when this conversation has been closed. |
Please inform the customer of conversation # 1152149 when this conversation has been closed. |
Moved from https://yoast.atlassian.net/browse/IM-1909
Reporter: @manuelaugustin
Description
We’ve encountered cased where people put very large base64-encoded data urls in their text (see attachment).
This not only crashes our analysis, but might also break browsers. So it’s bad practice to do this.
Detailed information provided by @jono :
This might be a common problem:
We could implement check for base64 images above a certain size in our Paper early in the analysis loop to display a warning about too large base64 images crippling your website (and our analysis).
description.txt
The text was updated successfully, but these errors were encountered: