-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Premium: Remove install/activate nag for Yoast SEO when using both as mu-plugins #18706
Comments
also: |
+1 for this. |
The other approach here could be that the Wordpress SEO plugin could just have a filter to provide the version to other plugins. e.g. in the non premium version: add_filter('wp_seo_current_version', function($version) {
return '1.1.1';
}, 10, 1); Then in the premium plugin the version would be checked with:
If the plugin is installed and active, the version would be returned as '1.1.1'. If it was not installed the $value would be '0'. This would mean a version would be returned regardless of whether it's a plugin or mu-plugin. Only caveat here is that another plugin could fake the version by returning a value from this filter (but why would they?) |
+1 |
bump |
Is your feature request related to a problem? Please describe.
when we run
yoast/wordpress-seo
andyoast/wordpress-seo-premium
as mu-plugins (courtesy ofroots/bedrock-autoloader
) we still get the nag to activate the base plugin:Describe the solution you'd like
this is a patch for
wordpress-seo-premium/src/addon-installer.php
i have tried locally, please consider adding it toyoast/wordpress-seo-premium
:Why do you think this feature is something we should consider for the Yoast SEO plugins?
some people like to use mu-plugins to streamline all the requirements without having to manually activate and keep databases in sync.
The text was updated successfully, but these errors were encountered: