Prevent fatal error on erroneous options on PHP 8.0+ #18282
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
count()
. Therefore the default option value of[]
will error and we would want to return before that.Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
$this->options_helper->get( 'workouts_data', [] );
to return something like[][][]
, but that does not work and isn't clear. So eventually opted to just return false if the default empty array is detected.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
wordpress-seo/src/integrations/admin/workouts-integration.php
change line 480$workouts_option = $this->options_helper->get( 'workouts_data', [] );
to$workouts_option = [];
to emulate the return of a default empty array.Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Fixes #17961