Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling inside FAQ Block causes titles to break #17252

Closed
4 of 9 tasks
timofey-drozhzhin opened this issue Jul 17, 2021 · 1 comment
Closed
4 of 9 tasks

Styling inside FAQ Block causes titles to break #17252

timofey-drozhzhin opened this issue Jul 17, 2021 · 1 comment

Comments

@timofey-drozhzhin
Copy link

timofey-drozhzhin commented Jul 17, 2021

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened.

Whenever bold text is pasted into FAQ Block title, it pastes <strong> tags inside <strong> tags, breaking titles. It's not html5 valid to have <strong> tags inside <strong> tag.
This issue may be in some ways related to #17221.

Screen Shot 2021-07-17 at 1 38 59 PM
Screen Shot 2021-07-17 at 1 39 17 PM

Please describe what you expected to happen and why.

Text pasted inside FAQ Block titles should be stripped of html, especially for <strong> tags, since the titles are already wrapped inside <strong> tags.

How can we reproduce this behavior?

  1. Copy bold text (wrapped in <strong>) from either a Google Document or a web page.
  2. Paste text inside Yoast FAQ Block title.
  3. Publish the page and examine the generated HTML.

Technical info

  • If relevant, which editor is affected (or editors):
  • Classic Editor
  • Gutenberg
  • Classic Editor plugin
  • Which browser is affected (or browsers):
  • Chrome
  • Firefox
  • Safari
  • Other

Used versions

  • WordPress version: 5.7.2
  • Yoast SEO version: 16.7 Premium
  • Gutenberg plugin version:
  • Classic Editor plugin version:
  • Relevant plugins in case of a bug:
  • Tested with theme:
@Djennez
Copy link
Member

Djennez commented Jul 19, 2021

I feel that between #17221 , #11802 and #11801 this is pretty much covered. So to prevent too many duplicate / related issues, I am closing this as a duplicate.

@Djennez Djennez closed this as completed Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants