Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and sponsored to the button link #16080

Open
1 of 3 tasks
alessandrolioce opened this issue Sep 21, 2020 · 9 comments
Open
1 of 3 tasks

Add and sponsored to the button link #16080

alessandrolioce opened this issue Sep 21, 2020 · 9 comments

Comments

@alessandrolioce
Copy link

The Yoast SEO plugin adds to the Gutenberg block editor the ability to indicate links within paragraphs as nofollow or sponsored. It would be a good idea to add this possibility also to the default "Button" block so that you can indicate the value of the rel attribute as or sponsored for this link as well.

immagine

immagine

Technical info

  • WordPress version: 5.5.1
  • Yoast SEO version: 14.9
  • If relevant, which editor is affected (or editors):
  • Classic Editor
  • Gutenberg
  • Classic Editor plugin
@Pcosta88
Copy link
Contributor

Please inform the customer of conversation # 670393 when this conversation has been closed.

@alessandrolioce
Copy link
Author

Hi, if I make the necessary changes, would you accept the pull request? Thanks

@Branch
Copy link

Branch commented Feb 28, 2023

+1 for this feature request.

Is there any update to this or is it under consideration?

@suascat
Copy link

suascat commented Feb 28, 2023

Please inform the customer of conversation # 993253 when this conversation has been closed.

@suascat
Copy link

suascat commented Feb 28, 2023

@alessandrolioce Thank you for your interest in contributing. We really appreciate it. Before submitting PR please read carefully these guidelines.

Note: Community pull requests need to go through our development team for review. Our team will assess the pull request and it will be given a priority level. Our developers work on the highest priority issues first. Unfortunately, this means we cannot give you an estimate of when they'll start working on your report, but we hope that it will be reviewed very soon.

@mikezielonka
Copy link

This would be awesome to see soon! :)

@thelawstudentswife
Copy link

Would love to see this, please!! It would make my life so much easier as a content creator.

@jeroenrotty
Copy link
Contributor

When we consider this, we might also look at potentially adding the functionality to other core blocks where a link can be added.

@jeroenrotty jeroenrotty added the IM label Apr 25, 2023
@Jordi-PV Jordi-PV self-assigned this Jan 17, 2024
@mhkuu
Copy link
Contributor

mhkuu commented Feb 19, 2024

We've had a look in our development team but unfortunately the code adding this functionality is old and quite complex, and rebuilds the core/link block instead of extending it -- that might have been a good solution at the time, but doesn't allow for proper modularization currently.

We will return to this feature request at a later point, for anyone taking a look then or in the meantime, the relevant code lives in packages/js/src/inline-links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.