Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yoast is not pinned in Gutenberg sidebar by default #14724

Closed
1 of 3 tasks
dariaknl opened this issue Apr 6, 2020 · 4 comments
Closed
1 of 3 tasks

Yoast is not pinned in Gutenberg sidebar by default #14724

dariaknl opened this issue Apr 6, 2020 · 4 comments

Comments

@dariaknl
Copy link
Contributor

dariaknl commented Apr 6, 2020

The issue comes from version which is still not released by Gutenberg, I was not able to find when they want to release.

How can we reproduce this behavior?

  1. Checkout gutenberg version from master branch.
  2. Activate gutenberg.
  3. Install and activate Yoast SEO 13.4.1..
  4. Start creating new post in incognito browser (to make sure all settings are default)
    You see that Yoast is not pinned anymore:

Screenshot 2020-04-06 at 08 13 55

  1. Click Tools and see that Yoast appears in Plugin section:

Screenshot 2020-04-06 at 08 14 36

  1. Click Yoast, and you get Yoast sidebar, but it is still not pinned in toolbar:

Screenshot 2020-04-06 at 08 15 23

  1. Click to pin ("star") on top, then you get Yoast sidebar pinned in toolbar:

Screenshot 2020-04-06 at 08 18 18

Problems:

  1. If we can get Yoast SEO pinned in toolbar by default (as it is now) - that would be good. Otherwise our plugin in sidebar is not visible anymore, especially for customers who are not active users of Gutenberg.
  2. Another issues is related to Plugin session which you see in step 5: Yoast plugin used to have Y logo there, but it got lost and is not shown anymore (this is also reproduce in 7.8.1)

Technical info

  • If relevant, which editor is affected (or editors):
  • Classic Editor
  • Gutenberg
  • Classic Editor plugin

Used versions

  • WordPress version: 5.4
  • Yoast SEO version: 13.4.1
  • Gutenberg version: master branch
@afercia
Copy link
Contributor

afercia commented Apr 9, 2020

Related Gutenberg change: WordPress/gutenberg#20698

Also:
in the Tools menu > Plugin section, there should be an icon close to plugin name. It is missing.

Left: Gutenberg plugin deactivated. Right: Gutenberg plugin activated:

missing icon

@afercia
Copy link
Contributor

afercia commented Apr 9, 2020

Regarding the missing (not visible) icon: created an issue upstream. See WordPress/gutenberg#21506

This could also be solved on our side by just explicitly setting the width and height attributes on the passed SVG WPElement e.g. icon: <PluginIcon height="20" width="20" />. Reported upstream because it's a breaking change on Gutenberg master.

@afercia afercia removed their assignment Apr 10, 2020
@jdevalk
Copy link
Contributor

jdevalk commented Apr 15, 2020

Core Gutenberg team thought this was a bug, please create a bug on their repo.

@IreneStr
Copy link
Contributor

I've created a Gutenberg issue: WordPress/gutenberg#21635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants