Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Person/Organization UI #14460

Open
jonoalderson opened this issue Mar 2, 2020 · 10 comments
Open

Refine Person/Organization UI #14460

jonoalderson opened this issue Mar 2, 2020 · 10 comments
Labels

Comments

@jonoalderson
Copy link

https://github.com/Yoast/wordpress-seo/issues/14197 depends on refinements to our current Person/Organization selection UI. This ticket contains the groundwork for that issue.

Proposed improvements

Proposed refinements to options and wording for the 'Publisher' selection. This approach aims to make the instructions much clearer, simpler, and more consistent.

Selecting a Person

image

Selecting an Organization

image

@jonoalderson jonoalderson added component: interface Visual interface problems or enhancements Yoast: Schema Yoast Feature component: schema (JSON+LD) labels Mar 2, 2020
@jdevalk
Copy link
Contributor

jdevalk commented Mar 2, 2020

In your interface examples we show a warning even when the stuff seems correctly specified? Flagging for @luckickken and team to review this, although I agree this is a huge step forward.

@jdevalk
Copy link
Contributor

jdevalk commented Mar 2, 2020

My own bit of feedback: I think the dropdown should just contain "the thing" not a sentence. So:

This website is published by: |dropdown|

@jonoalderson
Copy link
Author

Warnings there for demonstrative purposes only; can/should be removed when there are valid values present.

RE: 'the thing', agreed. As I was iterating, that made more sense. Now, more and more of these fields are groups with labels aligned with fields, so we should do the same in the "Who publishes this website?" bit for consistency.

@luckickken
Copy link

luckickken commented Mar 2, 2020

I agree with @jdevalk. My feedback:

  1. I think the copy is somewhat repetitive (the title, the paragraph and the dropdown basically say the same thing), or is that intentional?
  2. For consistency I would either use the word 'publish' or 'produce'. Now they're both used ('publish' in the title and dropdown and 'produce' in de paragraph) which could be confusing
  3. There's something about the alert that suggests the user made a mistake. Perhaps rephrasing the message can solve this: "In order for structured data to work properly, be sure to set a name and logo."

@jonoalderson
Copy link
Author

  1. Intentional, but agreed, and stripping the select boxes to the value will fix that.
  2. It's 'publish' everywhere except specifically when it talks about 'producing content', to try and assist people who don't know what 'publish' means in this context.
  3. Omitted values are a mistake; we should make it clear that this is a problem.

@luckickken
Copy link

  1. Check
  2. That sounds weird to me. Doesn't that mean that 'produce' is simply a better choice of words for this setting?
  3. I agree that we should convey the importance of filling out those fields. The thing is that the user hasn't gotten to that part, so no mistake is made, yet. But that might be nit-picky on my part.

@jonoalderson
Copy link
Author

jonoalderson commented Mar 2, 2020

2: It's awkward. We need to be specific that we're asking about who 'Publishes' the website, because that's different to what the website's about / who's 'running' the website / who's writing the content / who made/built it. If we can think of better wording to convey that, I'd be very happy. This is the best I could come up with before I started questioning my sanity.

3: These should, eventually, be configured during the onboarding wizards / similar, so if you end up here with them blank you've already missed them and it's definitely a problem. Where that might not be the case is if you switch type, in which case, we shouldn't trigger the warning until you save?

@luckickken
Copy link

  1. Hm, I do think that 'publishes' can be confused with the literal act of 'publishing' (e.g. a post) in WordPress. But, I'm not sure if I have a better suggestion at this point, to be honest.

  2. Agreed. Sounds good!

@jdevalk
Copy link
Contributor

jdevalk commented Mar 6, 2020

Was just thinking: this is better for Local too, please make sure we mock that up and give them a proper issue to work on too, @jono-alderson

@jonoalderson
Copy link
Author

Was just thinking: this is better for Local too, please make sure we mock that up and give them a proper issue to work on too, @jono-alderson

Already done!
https://github.com/Yoast/wordpress-seo-local/issues/1993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants