Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a logger in the indexables #14459

Closed
igorschoester opened this issue Mar 2, 2020 · 1 comment · Fixed by #15156
Closed

Implement a logger in the indexables #14459

igorschoester opened this issue Mar 2, 2020 · 1 comment · Fixed by #15156
Labels
component: indexables type: development

Comments

@igorschoester
Copy link
Member

igorschoester commented Mar 2, 2020 •
edited

When there is an exception in our ORM layer we catch this and ignore it.
We should log this instead, using our NullLogger.

These empty catch implementations live in the src folder. Search for catch. For example here: https://github.com/Yoast/wordpress-seo/blob/trunk/src/builders/indexable-post-builder.php#L315

The NullLogger is located here: https://github.com/Yoast/wordpress-seo/blob/trunk/src/loggers/logger.php

Please do this from the feature/indexables-frontend branch!

For bonus points: add an actual logger to the Yoast test helper repo that you can toggle on/off, overriding the NullLogger.
@igorschoester igorschoester self-assigned this May 12, 2020
@igorschoester igorschoester mentioned this issue May 12, 2020
Merged
4 tasks
@IreneStr IreneStr added the 0.5 label May 14, 2020
@igorschoester
Copy link
Member Author

Created a new issue on the test helper for the bonus points Yoast/yoast-test-helper#87

@igorschoester igorschoester removed their assignment May 14, 2020
@hansjovis hansjovis self-assigned this May 15, 2020
@hansjovis hansjovis removed their assignment May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: indexables type: development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add logger calls for the indexables Yoast/wordpress-seo
3 participants
@hansjovis @IreneStr @igorschoester