Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Width Popover from FAQ Images #14261

Closed
6 of 8 tasks
mustafauysal opened this issue Jan 22, 2020 · 3 comments
Closed
6 of 8 tasks

Remove Width Popover from FAQ Images #14261

mustafauysal opened this issue Jan 22, 2020 · 3 comments

Comments

@mustafauysal
Copy link

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened.

A random Width field showing after 'Add Image' to FAQ block - https://cloudup.com/cHpyq5k0kOP

Please describe what you expected to happen and why.

I've expected the "width" popover is not being there. It would be much better if we are able to control image size like the core image component.

How can we reproduce this behavior?

  1. Add a FAQ block
  2. Add an image
  3. Click on the image

Technical info

  • If relevant, which editor is affected (or editors):
  • Classic Editor
  • Gutenberg
  • Classic Editor plugin
  • Which browser is affected (or browsers):
  • Chrome
  • Firefox
  • Safari

Used versions

  • WordPress version: 5.3.2
  • Yoast SEO version: 12.9.1
@Djennez
Copy link
Member

Djennez commented Jan 22, 2020

What is the "bug" here exactly?

@rickalee
Copy link

This width overlay UI is inconsistent with core Image Block and could be confusing to users.

@Djennez
Copy link
Member

Djennez commented Jan 28, 2020

Hmmm ok, I agree with that. However, this to me looks more of a feature request to implement default image Gutenblocks in the FAQ block. I'll close this issue and add a reference on this thread. If you have any additional comments or questions, please leave them over there, or here. I'll read them anyway :)

@Djennez Djennez closed this as completed Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants