-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On WP 5.3 getting the Upgrade WordPress to the most recent version notice #13861
Comments
Hi @garretthyder and thanks for the report! I was able to reproduce the issue and I think I found the cause. It seems to be in the upgrade order of our plugin and WordPress. Up until Yoast 12.4 we have had a notification being output in the notification center if you were running older versions of WordPress. The function that decided if this notification should be shown was removed in Yoast 12.5. It looks like that if you upgrade Yoast from 12.4 to 12.5 while this notification is shown, it will not clear the notification from the database. So the notification stays persistent as a database entry (in Possible workarounds:
For the product team:
|
Please inform the customer of conversation # 559250 when this conversation has been closed. |
Thanks @Djennez I appreciate you taking the time to reproduce and confirm the issue. I was able to find and remove the wp_yoast_notifications user meta and remove the notification due to your insight, thanks. |
Please inform the customer of conversation # 559648 when this conversation has been closed. |
Hi I noticed the same issue. However I was not running behind on updates (unless a few days is considered finally deciding to upgrade). The timing of the 5.3 update and the 12.5 update of yoast was pretty close together 5.3 came out on 12th Nov and yoast 12.5 came out on 14th Nov (as far as I can tell). I upgraded both on 17th Nov (I was running the prior latest version of wordpress (which according to the definition should have also still been supported, as in current + previous). I upgraded the yoast plugin first (as I always do before updating to a new version of wordpress). The fact that It is now telling me that my wordpress version is out of date indicates a problem with Yoast, as neither the version I am on, or the version I was on prior to the updgrade is unsuported by Yoast). As the timing of these updates would mean that MANY people could have the same problem that I did, All of them being people who are keeping their sites up to date, and not a case of them having ignored warnings to update before upgrading their plugin. I would suggest that it should be on Yoast to fix this issue (and remove the false warning) rather than expecting their users to jump through some hoops to try and fix it themselves. I just came to see if this was an acknowledged problem and whether a fix would be coming, I wasn't planning to say anything, but after reading the above, thought I should set the record straight :) BTW it is an excellent plugin! I just don't like seeing a bug being passed off as not really being a bug ;) Tony. |
Hi @wintermu7e , thanks for the feedback. It is most definitely a bug on our end, which is why I've asked our product team to prioritize it even though it doesn't break anything. The workarounds listed in my earlier post are merely for the users who want to have it fixed immediately, rather than waiting for one of our updates 😄 |
Please inform the customer of conversation # 559697 when this conversation has been closed. |
Thanks Djennez, I was reading it more like a "feature" ;) It seems to be a strange one. I had another site which the 12.5 update had been applied on the weekend and I hadn't updated the wordpress yet. I was expecting to get the same issue but no.... I was not getting the warning about updating, and after I updated to 5.3 I didn't get it either. So there may be something more to it. This particular site was a test site and had a different yoast warning (robots,txt blocking) as I don't want it being indexed... Whether that warning being present stops the problem I'm not sure. edit: BTW deactivating and reactivating worked for the two sites that I had that were showing the issue. |
Please inform the customer of conversation # 559969 when this conversation has been closed. |
Please inform the customer of conversation # 559999 when this conversation has been closed. |
Please inform the customer of conversation # 561263 when this conversation has been closed. |
Please inform the customer of conversation # 561989 when this conversation has been closed. |
Please inform the customer of conversation # 565101 when this conversation has been closed. |
Please inform the customer of conversation # 567127 when this conversation has been closed. |
Please inform the customer of conversation # 568098 when this conversation has been closed. |
Please inform the customer of conversation # 573730 when this conversation has been closed. |
Please give us a description of what happened.
On our website bci.ca it's updated to 5.3 which I can confirm from the admin footer, the about screen, Site Health and version.php. However Yoast presents a notice about upgrading;
![Screen Shot 2019-11-15 at 1 50 49 PM](https://user-images.githubusercontent.com/8726005/68978713-62b6b100-07b0-11ea-8fbd-b6055f4c95b5.png)
And the link provided contains 5.2.4 which indicates to me that Yoast things it's 5.2.4 and not 5.3.
https://yoa.st/old-wp-support?php_version=7.2&platform=wordpress&platform_version=5.2.4&software=free&software_version=12.4&days_active=30plus&user_language=en_CA
Please describe what you expected to happen and why.
I didn't expect to see this notice as I'm on the latest WP.
Note: we have a mimic site on icb.eclipseserve.tk which is locked down but doesn't have the issue. So it seems to be a hosting thing potentially.
How is the version information determined?
Thanks
How can we reproduce this behavior?
Technical info
Used versions
The text was updated successfully, but these errors were encountered: