Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Twitter username to Twitter profile URL #12629

Open
hedgefield opened this issue Apr 9, 2019 · 8 comments
Open

Change Twitter username to Twitter profile URL #12629

hedgefield opened this issue Apr 9, 2019 · 8 comments

Comments

@hedgefield
Copy link
Contributor

The social profiles fields in the plugin (and as of 11.0, under the company or person picker) are all structured to take a full URL. EXCEPT Twitter, which only asks for a username.

Screen Shot 2019-04-09 at 11 55 17

Make this uniform, so that everything takes a full URL.

@hedgefield hedgefield changed the title Twitter username Twitter username > Twitter profile URL Apr 9, 2019
@hedgefield hedgefield changed the title Twitter username > Twitter profile URL Change Twitter username to Twitter profile URL Apr 9, 2019
@jonoalderson
Copy link

Hmm. I'm on the fence on this one.

I think it's easier, conceptually and practically, to write @jonoalderson than to go find my profile URL. I think it's actually a failing of the other platforms that there's no 'short version' equivalent.

I'd definitely support us making sure that our processing and parsing of that box correctly strips out and manages incorrect values, but also, perhaps we could add a placeholder of @username to the box?

@hedgefield
Copy link
Contributor Author

I'd be fine with the other way around too, but indeed not all platforms have an easy shorthand. Even with twitter username, do you put @jono or just jono? A placeholder would fix that confusion, but my main thing is I don't want to have everything say URL except this one field. Then we should do usernames wherever possible.

@bahia0019
Copy link

I agree that each should be consistent. URLs or profiles. It's bad usability to have 1 odd man out. And it's just plain weird.

Currently there seems to be some validation that converts an entered URL to the Username.
Perhaps something in reverse could be implemented as well.

@jpanther
Copy link

This is actually causing a real issue in the twitter:creator meta tag because Wordpress core user profile page asks for the 'Twitter URL' and Yoast is incorrectly assuming this field contains the Twitter username (maybe it used to be this in prior versions of Wordpress?). As a result the twitter:creator tag shows a value of @https://twitter.com/username which is obviously incorrect.

The workaround is to change the user profile 'Twitter URL' field to only contain the Twitter handle however this then breaks themes and other Wordpress core functionality where author boxes, etc expect this field to be the full Twitter URL. Yoast should really change to use Twitter URL as it's consistent with the Wordpress core user profile and will avoid this issue completely.

@Djennez
Copy link
Member

Djennez commented Aug 13, 2020

@jpanther as far as I can find, our plugin only deals with the username. Both on the user profile page (Twitter username (without @) ) as well as in the SEO -> Social settings (Twitter Username). The twitter:creator generator also only handles in usernames. If you're required to put a Twitter URL somewhere, I guess it's not our plugin that is handling that.

@jpanther
Copy link

@Djennez Okay sorry, I just did a bit more digging and it turns out the theme is renaming that field on the user profile screen!!! I'll bring this up with the theme author.

@bahia0019
Copy link

How is this still an issue?
Why is the the field for Twitter the ONLY field that isn't a URL?
It should be consistent with the other fields. Or, at least provide the option for users to add URL or @name, then format it programmatically .

It's just poor usability.

@smkrause
Copy link

smkrause commented Feb 4, 2021

Running into this issue more and more with different themes and plugins which are expecting a URL, not a handle. +1 @bahia0019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants