Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification center internal working rework #12289

Open
moorscode opened this issue Feb 22, 2019 · 0 comments
Open

Notification center internal working rework #12289

moorscode opened this issue Feb 22, 2019 · 0 comments

Comments

@moorscode
Copy link
Contributor

The notification center currently stores the data of notifications in user options.
This means that if a notification is removed but no unregistered, the notification will still remain present.

This causes problems in several cases:

  • Addons throw notifications - the addon gets disabled
  • Upgrade routines - notifications are removed in a specific version

Suggested change:

  • Instead of saving the data of a notification, just store the ID and the state of muted/dismissed

If a notification/state of the site is present or not is checked on every request.
A refactor on where notifications exist sounds like a good addition. These should not have to live in separate contexts. If they are bundled together in a "Site Health" class the overview of which notification exist and when they are triggered would be much more transparent.

Needing some eyes/approved approach from the architects team (cc @atimmer / @herregroen)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants