Saving Features triggers two admin notices for 'Settings saved.'

[garretthyder]

• I've read and understood the contribution guidelines.
• I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened.

When saving changes to the Features tab the page reloads but displays two 'Settings saved.' notices. Only need the one.

Please describe what you expected to happen and why.

Was expecting to see the 'Settings saved.' notice appear but wasn't expecting it to be duplicated.

How can we reproduce this behavior?

1. Navigate to Features
2. Toggle something
3. Click 'Save changes'
4. Wait for the reload and display of admin notices.
5. Notice there's two 'Settings saved.' notices.

Screenshots

Technical info

• Which browser is affected (or browsers):

• Chrome
• Firefox
• Safari
• Other

Used versions

• WordPress version: 5.0.3
• Yoast SEO version: 9.6

[Djennez]

Hi @garrett-eclipse , I am unable to reproduce this behaviour. Can you confirm that this happens on more than one WordPress installation and does it happen with deactivated (other than Yoast) plugins as well?

[garretthyder]

Thanks for testing @Djennez you're right it seems to be a plugin conflict. I'd just seen it on multiple installs but since most have the same stack not surprised they had the same issue. After investigation, I've narrowed down the conflict to ShareThis Share Buttons w/ Yoast SEO and confirmed on a clean instance with just them installed.
Plugin - https://wordpress.org/plugins/sharethis-share-buttons/

As it only occurs on the Yoast admin screen and not the ShareThis one would you mind taking a look and letting me know if the issue resides on ShareThis side.

I've also opened a ticket with them to look into this.
ShareThis Ticket - https://wordpress.org/support/topic/conflict-w-yoast-seo-causing-double-notices/

Appreciated

[Djennez]

Ah, I am able to reproduce the issue. For some reason, their plugin calls the settings_errors() function on our page once you hit the Save settings button. This triggers a double call to that function which creates 2 notices. It seems that there is no checking or sanitation in the code of the ShareThis plugin to check which page is active. This needs to be fixed on their end as far as I can see.

[garretthyder]

Thanks @Djennez for taking a look.
I've updated the ShareThis ticket - https://wordpress.org/support/topic/conflict-w-yoast-seo-causing-double-notices/#post-11246231
And we'll leave this in their court.