Make sure we are in The Loop state #12107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `the_content` filter should assume we are in the loop, and can call global functions, we need to prepare the environment to act that way. Because WordPress backend does not use The Loop, we need to restore the set globals to their previous state, instead of doing a `wp_reset_postdata`
|
This has been open without action for ~two years. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 In discussion, DO NOT MERGE 🚧
As
the_contentfilter should assume we are in the loop, and can call global functions, we need to prepare the environment to act that way.Because WordPress backend does not use The Loop, we need to restore the set globals to their previous state, instead of doing a
wp_reset_postdata.Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
wp_reset_postdatawill leave the system in a different state than before. This might cause unwanted side-effects.Test instructions
This PR can be tested by following these steps:
UI changes
This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.Quality assurance
Fixes #11395