-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Information stored in wpseo_taxonomy_meta in the wp_options won't be cleaned up #11268
Comments
Thanks for reporting this bug! I've been able to confirm this. |
Please inform the customer of conversation # 587163 when this conversation has been closed. |
So, just providing some context on this for people running into this and for if this needs to get fixed. When a taxonomy gets deleted, we don't delete the associated WPSEO data from the Looking at a small example of
This contains data for the
These are for the tags with IDs 95 and 93. I have already deleted the tag with ID 95 so this data is outdated and could be removed. However, to the question why would you delete this data? I don't believe this option has a large impact on normal sites. If you have thousands upon thousands of taxonomies with different SEO metadata, it might cause some impact, but I am unable to test or verify this claim. |
Conv # 587163 said
Note: Customer provided us with the data stored in the field. I noticed quite a few empty data strings. (Screenshot below.) Do we need to store empty strings? |
Please inform the customer of conversation # 628267 when this conversation has been closed. |
Please inform the customer of conversation # 634424 when this conversation has been closed. |
Please inform the customer of conversation # 647116 when this conversation has been closed. |
Please inform the customer of conversation # 679177 when this conversation has been closed. |
Please inform the customer of conversation # 750636 when this conversation has been closed. |
Please inform the customer of conversation # 805049 when this conversation has been closed. |
Please inform the customer of conversation # 835226 when this conversation has been closed. |
Please inform the customer of conversation # 863970 when this conversation has been closed. |
Please inform the customer of conversation #889444 when this conversation has been closed. |
Please inform the customer of conversation # 1003486 when this conversation has been closed. |
Please inform the customer of conversation # 1021202 when this conversation has been closed. |
Please inform the customer of conversation # 1071308 when this conversation has been closed. |
Please inform the customer of conversation # 1110008 when this conversation has been closed. |
Please inform the customer of conversation # 1134424 when this conversation has been closed. |
Hi @Djennez, given that this issue apparently keeps popping up in support requests again and again over the years, do you plan to add logic that cleans up the
Well, the simplest answer is data minimization and preventing "data garbage" on your customer's systems as much as possible. But more importantly, there are real-life cases where this ever-growing option causes issues, e.g., here: https://wordpress.org/support/topic/wpseo_taxonomy_meta-causing-and-autoloaded-data/. TBH, I'm surprised cleaning up hasn't been introduced after all those years, given that this is a really simple fix: Hook to the I'd really appreciate it if you could consider adding this! Thanks! |
Please give us a description of what happened.
When deleting a category, post_tag, custom_taxonomy, the information, stored inside the option 'wpseo_taxonomy_meta' won't be deleted, though these information are lost forever, since they are bound to an id, which will never be given again.
Please describe what you expected to happen and why.
Obviously, delete the information alongside with deleting a term within a taxonomy.
How can we reproduce this behavior?
Technical info
The text was updated successfully, but these errors were encountered: