Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New FAQ block text format #11018

Open
4 of 10 tasks
QROkes opened this issue Sep 16, 2018 · 32 comments
Open
4 of 10 tasks

New FAQ block text format #11018

QROkes opened this issue Sep 16, 2018 · 32 comments

Comments

@QROkes
Copy link

QROkes commented Sep 16, 2018

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened.

Using the new FAQ block and trying to give some format to the answer, I tried "pre", "ul/li" and "p" and it was not possible. After "editing in html" wordpress ask me convert to block because it was modified and remove all these changes.

Please describe what you expected to happen and why.

Would be nice having an option to add some basic format to the answers.

  • Enter insert a "br" instead a new paragraph "p". Would be nice have more than one paragraph for answers.
  • Lists "ul/li" and "pre" should be allowed.

How can we reproduce this behavior?

  1. Add a new FAQ Block (yoast).
  2. Edit as HTML and try to add a "pre" formating.
  3. Come back to edit visually.
  4. WP will ask you to convert to block, after that, the new "pre" tags added will be removed.

Technical info

  • WordPress version: 4.9.8

  • Yoast SEO version: 8.2

  • If relevant, which editor is affected (or editors):

  • Classic Editor
  • Gutenberg
  • Classic Editor plugin
  • Which browser is affected (or browsers):
  • IE11
  • Edge
  • Chrome
  • Firefox
  • Safari
  • Relevant plugins in case of a bug:
  • Tested with theme:
    Genesis Framework
@CarolineGeven
Copy link
Contributor

Thank you for reporting this issue. We'll discuss this enhancement internally to see if it is something we can and will add.

@mikalehmann
Copy link

This suggestion also aligns with Google's recommendations:

The full answer to the question. The answer may contain HTML content such as links and lists. Valid HTML tags include: <h1> through <h6>, <br>, <ol>, <ul>, <li>, <a>, <p>, <div>, <b>, <strong>, <i>, and <em>.

Being able to use lists in the Answer field would be really useful.

@rmarcano
Copy link

Please inform the customer of conversation # 541800 when this conversation has been closed.

@Pcosta88
Copy link
Contributor

Please inform the customer of conversation # 542502 when this conversation has been closed.

@QROkes
Copy link
Author

QROkes commented Sep 30, 2019

Also, each question should contain an individual "id" for better linking.
<h3 id="first-question">

@Pcosta88
Copy link
Contributor

Pcosta88 commented Nov 8, 2019

Please inform the customer of conversation # 556923 when this conversation has been closed.

@bubblund
Copy link

bubblund commented Jan 3, 2020

Has there been any progress with adding support for the ul, ol and li tags in the How To and FAQ blocks?

@Djennez
Copy link
Member

Djennez commented Jan 6, 2020

This has no priority at the moment, as far as I know.

@Pcosta88
Copy link
Contributor

Pcosta88 commented Jun 1, 2020

Please inform the customer of conversation #616555 when this conversation has been closed.

@priscillamc
Copy link

Request to replace the <strong> tag with `a <div>

@lazharichir
Copy link

The UL/OL/LI tags are especially important when it comes to giving clear short-form answers to questions.

@webprom
Copy link

webprom commented Jun 28, 2020

I need at least LISTS there too.

@Bylyme
Copy link

Bylyme commented Aug 17, 2020

+1 for ul / ol / li

@mkronenfeld
Copy link
Contributor

+1

It would be already sufficient, if the block does not collapse, if you insert a list via the HTML editor.

@acegoulet
Copy link

+1 for ul / ol / li

@eric-michel
Copy link

+1 - this block is necessary for well-built sites that contain an FAQ, but the lack of at least a ul option is pretty limiting.

@michaelbriantina
Copy link

Please inform the customer of conversation # 674678 when this conversation has been closed.

@Pcosta88
Copy link
Contributor

Pcosta88 commented Dec 2, 2020

Please inform the customer of conversation # 668719 when this conversation has been closed.

@QROkes
Copy link
Author

QROkes commented Dec 3, 2020

I will close this issue since I stopped using Yoast and also I built my own FAQ block and this issue is now solved for me. After more than 2 years open seems like it's not a priority here.

@Telsenome
Copy link

Do we have a timeline for when this potentially could be included?

@iryska
Copy link

iryska commented Apr 23, 2021

The same question here - Any timelines for tags? Especially for ul/ol/li/p?

@schutzsmith
Copy link

I will close this issue since I stopped using Yoast and also I built my own FAQ block and this issue is now solved for me. After more than 2 years open seems like it's not a priority here.

@QROkes is it possible for us to get a copy of your FAQ solution?

@schutzsmith
Copy link

@michaelbriantina @moorscode @Djennez Is the addition of being able to use list items in the FAQ Block on your timeline at all? Trying to get a sense if we should wait for a fix or look for a different solution.

@QROkes
Copy link
Author

QROkes commented Sep 7, 2021

@schutzsmith just create your own block and use the "classic editor" inside your block instead of the "rich text" used by Yoast. Also, you can integrate your own SEO, for example, I decided to integrate my block with the Genesis Framework and take advantage of the Microdata markup, that in this specific case (FAQ pages) is better than the JSON solution implemented by Yoast that result very inefficient causing in some cases having pages unnecessarily of the double of the normal size because all the content is duplicated in the JSON.

@schutzsmith
Copy link

@schutzsmith just create your own block and use the "classic editor" inside your block instead of the "rich text" used by Yoast. Also, you can integrate your own SEO, for example, I decided to integrate my block with the Genesis Framework and take advantage of the Microdata markup, that in this specific case (FAQ pages) is better than the JSON solution implemented by Yoast that result very inefficient causing in some cases having pages unnecessarily of the double of the normal size because all the content is duplicated in the JSON.

Thanks for the insight!

@eric-michel
Copy link

Resurrecting this issue.

I have a working prototype of an FAQ block that closely follows how Yoast's FAQ block creates its schema, but allows much more flexibility in markup.

It functions with a combination of two blocks: the FAQ wrapper block, and an FAQ Answer block.

The FAQ wrapper block simply contains InnerBlocks with a locked block template of a single Heading block (the question) and an FAQ Answer block (the answer). This allows the question to be any level of heading (not just <h2>).

The FAQ Answer block contains an InnerBlocks that is limited to Heading, Paragraph, and List blocks. This allows for the full range of HTML tags that the schema supports:

The answer may contain HTML content such as links and lists. Valid HTML tags include: <h1> through <h6>, <br>, <ol>, <ul>, <li>, <a>, <p>, <div>, <b>, <strong>, <i>, and <em>.

The block injects the appropriate schema data via Yoast\WP\SEO\Generators\Schema.

Any number of FAQ blocks can be added to the page, and are not locked to a single overall wrapper block that forces them to be in a single place (so you can have regular content separating questions).

Is there any interest from the Yoast team in integrating this block into wordpress-seo proper? I would be happy to contribute, but don't want to rework this into an appropriate PR if there isn't any momentum behind this issue. I would also need help from someone to create an appropriate upgrade path from the existing FAQ block to this new one as they're so different.

@michaelbriantina
Copy link

@ogodoabiola
Copy link

Please inform the customer of conversation # 908094 when this conversation has been closed.

@colinduwe
Copy link

@eric-michel Did you submit a pull request with your prototype or do you have it somewhere you would be willing to share? I'd love to get this functionality into a site I'm building.

@eric-michel
Copy link

eric-michel commented Sep 13, 2022

@colinduwe Unfortunately I never got any response from someone willing to help me out with a PR, so I never reworked it. It's also not really in a refined state (more of a proof-of-concept at the moment), but if all goes according to plan I'll be using it on a site soon and will get it cleaned up and documented in the next couple months. I'll see about sharing the code then (originally I gave a link but just realized it's a private repo at the moment, and I need to check with others on whether we're willing to share it with folks other than Yoast).

@maybellyne
Copy link

Please inform the customer of conversation # 1096268 when this conversation has been closed.

@asafm7
Copy link

asafm7 commented Feb 12, 2024

@jeroenrotty @jeroenrotty are there any updates on this? Is it planned?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests