Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Check if the keyword has been used before is missing #1150

Closed
benvaassen opened this issue May 24, 2017 · 2 comments
Closed

Check if the keyword has been used before is missing #1150

benvaassen opened this issue May 24, 2017 · 2 comments
Labels

Comments

@benvaassen
Copy link

benvaassen commented May 24, 2017

The check would tell me if I've used a focus keyword before. A red bullet if I've used it 2 times or more, an orange bullet if I did use it once before, green bullet if I didn't. All three checks are missing in Yoast SEO 4.8.

  • You've never used this focus keyword before.
  • You've used this focus keyword once before, be sure to make very clear which URL on your site is the most important for this keyword.
  • You've used this focus keyword 2 times before, it's probably a good idea to read this post on cornerstone content and improve your keyword strategy.

How can we reproduce this behavior?

  • Create a new post
  • Set the focus keyword to meta keyword
  • Publish
  • Create a new post
  • Set the focus keyword to meta keyword

In Yoast SEO 4.8:
add_new_post_ dev_wordpress _wordpress

In Yoast SEO 4.7.1:
add_new_post_ dev_wordpress _wordpress

Technical info

  • Platform: WordPress
  • Platform version: 4.7.5
  • Yoast SEO version: 4.8
@boblinthorst
Copy link
Contributor

boblinthorst commented May 26, 2017

I did some research trying to fix this one. Didn't have the time fix it. It was a bit of a rabbit hole.

It seems the previouslyUsedKeywords assesment is correctly added to the list of assessments. But somewhere between the addition of the assesment and the execution of all assessments, it is removed.

With the addition of cornerstone content, another assessor was added for cornerstone content. To switch between assessors, depending on whether it is cornerstone or not, a different assessor is used.

However, in the process, a new assessor is created, which leaves behind all assessments not added in the initiation of the new assessor. PreviouslyUsedKeyword is added, and then the assessor is immediately replaced with another. Another example is the YoastLocalSEO-localStorelocatorContent assessment, which is also breaks as well.

Concluding, we need to think a bit more about the way we switch assessors. Thanks @terw-dan for helping me discovering this one.

@Pcosta88
Copy link

@benvaassen Consider re-opening as issue still happens: Yoast/wordpress-seo#7012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants