Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fallback if favicon cannot be resolved in snippet preview #50

Closed
Sebobo opened this issue Sep 16, 2019 · 1 comment
Closed

Use fallback if favicon cannot be resolved in snippet preview #50

Sebobo opened this issue Sep 16, 2019 · 1 comment

Comments

@Sebobo
Copy link
Collaborator

Sebobo commented Sep 16, 2019

Currently the snippet preview tries to render the favicon.ico in the web folder and will render an error in the browser console if none is found. Also the is a white space instead of the favicon in the search preview.

But the favicon might not exist or another favicon is linked in the page metadata.
Therefore the linked one should be used or a fallback if no favicon is found at all.

@Sebobo
Copy link
Collaborator Author

Sebobo commented Sep 21, 2019

Fixed in 1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant