Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fanart for allocine plugin, patch inside #617

Closed
Omertron opened this issue Mar 15, 2015 · 10 comments
Closed

add fanart for allocine plugin, patch inside #617

Omertron opened this issue Mar 15, 2015 · 10 comments

Comments

@Omertron
Copy link
Member

Original issue 618 created by Omertron on 2009-03-12T06:35:00.000Z:

Allocine Plugin don't support fanart.
Could you add the patch for this plugin.

@Omertron
Copy link
Member Author

Comment #1 originally posted by Omertron on 2009-03-12T10:22:31.000Z:

<empty>

@Omertron
Copy link
Member Author

Comment #2 originally posted by Omertron on 2009-03-12T12:44:04.000Z:

Ok, I'll merge and test it.
I suppose you (Jerome) have already test it.

@Omertron
Copy link
Member Author

Comment #3 originally posted by Omertron on 2009-03-12T12:47:53.000Z:

Ok, I'll merge and test it.
I suppose you (Jerome) have already tested it.

@Omertron
Copy link
Member Author

Comment #4 originally posted by Omertron on 2009-03-12T13:09:27.000Z:

Yes, me and another person have tested
It works perfectly for us.

@Omertron
Copy link
Member Author

Comment #5 originally posted by Omertron on 2009-03-12T15:11:31.000Z:

Groll, I thought that as your plugin you were best to ensure it worked.
I'd be happy to merge it, but I wouldn't be able to test it 100%

@Omertron
Copy link
Member Author

Comment #6 originally posted by Omertron on 2009-03-12T15:18:23.000Z:

No problem Stuart, you did the right thing.
I'll do the merge and (little) testing. ;)

@Omertron
Copy link
Member Author

Comment #7 originally posted by Omertron on 2009-03-16T14:49:38.000Z:

I don't know, but as IMDB works fine for fanart could it be possible to download
fanart from Imdb and infos from allocine ?

@Omertron
Copy link
Member Author

Comment #8 originally posted by Omertron on 2009-03-16T15:26:14.000Z:

yes, this patch makes it

@Omertron
Copy link
Member Author

Comment #9 originally posted by Omertron on 2009-03-16T16:02:20.000Z:

Actually, I'm looking at changing how fanarts are downloaded for issue 512. It's not
difficult to patch each of the plugins to match the IMDB plugin, but it's not very
elegant. It should be available to all plugins anyway.

Go ahead and commit this change and I'll alter it when I get issue 512 sorted.

@Omertron
Copy link
Member Author

Comment #10 originally posted by Omertron on 2009-03-16T16:09:16.000Z:

Stuart : I just commit my task a few minutes before your last comment.
Jerome : Your patch only work for TV Shows, I added movies support.

Done in release R833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant