Ratings.xml not working as expected!

[Omertron]

Original issue 1873 created by Omertron on 2011-03-30T20:29:20.000Z:

Using r2245 to test new ratings-default.xml file by overriding with my-ratings.xml and setting

# Ratings file used for enabling/renaming catgories
mjb.xmlRatingFile=my-ratings.xml


And part of my-ratings.xml contains...
<ratings>
    <rating name="G">
        <subrating>General</subrating>
        <subrating>6</subrating>
        <subrating>AL</subrating>
        <subrating>All</subrating>
        <subrating>Atp</subrating>
        <subrating>Approved</subrating>
        <subrating>TV-G</subrating>
        <subrating>TV-Y</subrating>
        <subrating>TV-Y7</subrating>
        <subrating>TV-Y8</subrating>
        <subrating>M$2F6</subrating>
    </rating>
    <rating name="PG">
        <subrating>12</subrating>
        <subrating>13</subrating>
        <subrating>PT</subrating>
        <subrating>TV-PG</subrating>
        <subrating>Not Rated</subrating>
    </rating>
    <rating name="PG-13">
        <subrating>K-13</subrating>
        <subrating>13+</subrating>
        <subrating>14</subrating>
        <subrating>14+</subrating>
        <subrating>TV-14</subrating>
        <subrating>UNKNOWN</subrating>
        <subrating>Not Rated</subrating>
    </rating>
    <rating name="PG-14">
        <subrating>AA</subrating>
        <subrating>PA</subrating>
        <subrating>PG14</subrating>
        <subrating>K-15</subrating>
        <subrating>15</subrating>
        <subrating>16</subrating>
        <subrating>16+</subrating>
        <subrating>17</subrating>
        <subrating>TV-MA</subrating>
    </rating>
...

However for TV shows I get TV-G, TV-PG, TV-14, TV-Y7, TV-7
instead of G, PG, PG-13 as expected.

[Omertron]

Comment #1 originally posted by Omertron on 2011-03-31T13:40:01.000Z:

Can you provide the XML snippet for the ratings/certification for shows that are and aren't transformed?

[Omertron]

Comment #2 originally posted by Omertron on 2011-04-01T01:25:05.000Z:

These two examples show TV-Y7 but the XML files were newly re-generated.

---

81848 tt0852863 2.4-SNAPSHOT 2245 2011-03-30 00:23:53 Phineas And Ferb S00E02 - Christmas Vacation Phineas And Ferb S00E02 - Christmas Vacation <title>Phineas and Ferb</title> Phineas and Ferb Phineas and Ferb UNKNOWN UNKNOWN 83 false -1

Phineas%20And%20Ferb%20S00E02%20-%20Christmas%20Vacation.html

... 34m TV-Y 0 English ... UNKNOWN Comedy TV-Y TV Shows Phineas and Ferb P ...

---

159221 2.4-SNAPSHOT 2245 2011-03-30 01:15:27 Kick Buttowski S01E01 - Dead Man's Drop; Stumped Kick Buttowski S01E01 - Dead Man's Drop; Stumped <title>Kick Buttowski</title> ... 30 TV-Y 1 English ... Last Year Family TV-Y TV Shows Kick Buttowski K ...

[Omertron]

Comment #3 originally posted by Omertron on 2011-04-01T02:30:12.000Z:

So I removed all xml files for the first example above (seasons 0-2), and re-ran YAMJ.
I still get
TV-Y

[Omertron]

Comment #4 originally posted by Omertron on 2011-04-01T07:28:56.000Z:

Ok, I'll check later and update

Always useful to have examples

[Omertron]

Comment #5 originally posted by Omertron on 2011-04-02T08:39:33.000Z:

Tested with those files and that configuration. Works for me.

Make sure you have:

mjb.filter.ratings=true
mjb.xmlRatingFile=my-ratings.xml

in your properties file, and you overwrite the XML for those shows

[Omertron]

Comment #6 originally posted by Omertron on 2011-04-02T23:28:11.000Z:

Ok, missed mjb.filter.ratings=true -- to test later

I now see in default there's also mjb.filter.genres=false which must be new since I never overrode it in my config but it seemed to worked (probably wrong).

So then it seems to be missing mjb.filter.categories=false ?

Is this option for custom genres like 'home-movies'?
# List of genres to skip when scraping video information.
# These genres will not be saved in the video XML files
mjb.genre.skip=

What I see missing with all three filters is a drop-bucket filter.
That is, if 'name' matches nothing in filter file, put it in THIS category, such as OTHER or UNKNOWN. For example, if some rating shows up as "E", which I don't have filtered then put it into "G" or "Unrated". Perhaps a special category/filter placed at end of (rating/genre) file with <UNKNOWN>Unrated<... which means the category to use.

[Omertron]

Comment #7 originally posted by Omertron on 2011-04-03T05:40:53.000Z:

mjb.genre.skip is intended for those odd genres that some sites have that you don't care about or want in your jukebox at all. they are ignored, and not even placed in the jukebox.

For ratings you can add "UNKNOWN" and "Not Defined" to the list and place them in a category, but there's not a catch all group. that's a good idea, so submit it as a new enhancement