Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify XRT native C++ API usage with less headers to include #7002

Open
keryell opened this issue Sep 7, 2022 · 2 comments
Open

Simplify XRT native C++ API usage with less headers to include #7002

keryell opened this issue Sep 7, 2022 · 2 comments
Assignees

Comments

@keryell
Copy link
Member

keryell commented Sep 7, 2022

It is cumbersome to include many headers for an XRT application.
There should be a single header for most use cases, like xrt/xrt.h or xrt/xrt.hpp or xrt/xrt++.h or [bikesheding].
I think it makes sense today since XRT is becoming less experimental. There could be other includes for very specific/experimental features or extensions.

@bryanloz-xilinx
Copy link
Contributor

I agree here with @keryell. I also think its strange that the existing xrt.h is included by xrt/xrt_device.h it should be the other way around.

@stsoe
Copy link
Collaborator

stsoe commented Sep 20, 2022

yeah. well, but that xrt.h is completely different from what is being discussed here.

xrt.h is a legacy header file on top of which XRT C++ APIs are built, for example xcl typedefs are in xrt.h and are used in the C++ APIs. This was done early on when the C++ APIs were used in conjunction with xcl APIs. No longer the case, so some cleanup should be done.

Confusing indeed. I will address it as part of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants