-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actions -> download_artifact
fails with an auth issue
#563
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Downloading artifacts for actions no longer seems to work. This seems to be caused by the azure blob storage now preferring the authorization header information over the values provided by the query parameters.
Here's a blog post describing the issue for a golang library:
https://medium.com/@DiggerHQ/chasing-a-nasty-bug-a-tale-of-excessive-auth-40d8bf5cf192
It would be good perhaps for the
execute
function to not always add authorization headers to all requests (but maybe only to the ones that go to thebase_uri
). Adding it to all requests that go throughpub async fn execute
function regardless of the targetted URL might cause the library to leak credentials to other servers besides github.I am not familiar enough with the API to know whether changing this behaviour is a good idea (nor am I really experienced with writing Rust code, which is why I haven't created a PR).
The text was updated successfully, but these errors were encountered: