Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Opacity X-Ray #1024

Closed
4 tasks done
TanChenyu opened this issue Jun 22, 2024 · 3 comments
Closed
4 tasks done

Add Opacity X-Ray #1024

TanChenyu opened this issue Jun 22, 2024 · 3 comments
Labels
area:settings Improves the settings of existing features. category:render status:confirmed status:never-stale Prevents stalebot from marking this item as stale. type:enhancement New feature or request
Milestone

Comments

@TanChenyu
Copy link

TanChenyu commented Jun 22, 2024

Pre-suggestion checklist

  • I have searched existing issues and didn't find any previous issues with the same suggestion.
  • This is only one suggestion. I understand that GitHub issues don't work well with lists.
  • This feature doesn't already exist in the latest version of Wurst. I've made sure my installation is up to date.
  • I have looked at the code and am reasonably confident that this suggestion is possible to implement.

What type of improvement are you suggesting?

Changing the settings of existing features.

What type of player would find this improvement useful?

Miners

Description

Just like the title said. Add a frame of blocks that that adjacent to air and liquid when enabling X-Ray.
(I think CaveFinder can be delete if this feature added)

@TanChenyu TanChenyu added status:unconfirmed New issue. Needs triage. type:enhancement New feature or request labels Jun 22, 2024
@TanChenyu TanChenyu changed the title Highlight the blocks that adjacent to air when enabling X-Ray Highlight the blocks that adjacent to air (and liquid) when enabling X-Ray Jun 23, 2024
Copy link

This issue has been open for a while with no recent activity. If this issue is still important to you, please add a comment within the next 7 days to keep it open. Otherwise, the issue will be automatically closed to free up time for other tasks.

Issues should be closed if:

  • They are duplicates of other issues
  • There is not enough demand
  • They are no longer relevant
  • There are not enough details

@Alexander01998
Copy link
Member

Hey @TanChenyu,

Thanks for the suggestion! We actually already have a feature in the X-Ray settings called "Only show exposed" that does something very similar to what you're asking for. It makes X-Ray only show blocks that are adjacent to air or liquids, letting you quickly spot ores that are visible in caves.

Technically it doesn't highlight them with a frame around the blocks, like how Search or an ESP hack would, but that's also generally not something that X-Ray does and it's still quite easy to spot these blocks because of how X-Ray hides everything else.

I get that it could be useful to see both types of ores at the same time and have a frame around the exposed ones so that they stand out, but that honestly doesn't seem like a huge improvement to me. You can already make a keybind for .setcheckbox x-ray only_show_exposed toggle and quickly press that whenever you need to see the other ores.

Don't get me wrong, it would still be nice to not need a keybind for that. But to be honest, I've got a lot on my plate and there are other features that I think would make a bigger difference on gameplay.

As for CaveFinder, I think it still has its place and I'm not a fan of the idea just removing it.

@TanChenyu
Copy link
Author

TanChenyu commented Aug 23, 2024

Hey @TanChenyu,

Thanks for the suggestion! We actually already have a feature in the X-Ray settings called "Only show exposed" that does something very similar to what you're asking for. It makes X-Ray only show blocks that are adjacent to air or liquids, letting you quickly spot ores that are visible in caves.

Technically it doesn't highlight them with a frame around the blocks, like how Search or an ESP hack would, but that's also generally not something that X-Ray does and it's still quite easy to spot these blocks because of how X-Ray hides everything else.

I get that it could be useful to see both types of ores at the same time and have a frame around the exposed ones so that they stand out, but that honestly doesn't seem like a huge improvement to me. You can already make a keybind for .setcheckbox x-ray only_show_exposed toggle and quickly press that whenever you need to see the other ores.

Don't get me wrong, it would still be nice to not need a keybind for that. But to be honest, I've got a lot on my plate and there are other features that I think would make a bigger difference on gameplay.

As for CaveFinder, I think it still has its place and I'm not a fan of the idea just removing it.

Actually, what I want is to highlight ALL the blocks around air or liquids(not just ores), because I want to recognize underground air while using X-Ray(So that I won't be dropped into a cave or underground structure, and that why I thought CaveFinder won't be useful after this added)
Usually hacked clients use opacity option to help players recognize underground air, but I thought add frames is better for Wurst ^_^
Sorry for my unclear description. And thanks for your reply.

@Alexander01998 Alexander01998 removed the status:unconfirmed New issue. Needs triage. label Sep 19, 2024
@Alexander01998 Alexander01998 changed the title Highlight the blocks that adjacent to air (and liquid) when enabling X-Ray Add Opacity X-Ray Sep 19, 2024
@Alexander01998 Alexander01998 added area:settings Improves the settings of existing features. category:render status:confirmed status:never-stale Prevents stalebot from marking this item as stale. labels Sep 19, 2024
@Alexander01998 Alexander01998 added this to the v7.46 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:settings Improves the settings of existing features. category:render status:confirmed status:never-stale Prevents stalebot from marking this item as stale. type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants