From 7b1f75cd58327158d99bcacf295c7a868321c5e9 Mon Sep 17 00:00:00 2001 From: jasmussen Date: Mon, 1 Apr 2024 13:45:54 +0200 Subject: [PATCH 1/2] Try: Show copy shortcut in block options. --- .../block-settings-menu/block-settings-dropdown.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js b/packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js index abe453ec9f640..35571cf0d7aaa 100644 --- a/packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js +++ b/packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js @@ -11,6 +11,7 @@ import { useDispatch, useSelect } from '@wordpress/data'; import { moreVertical } from '@wordpress/icons'; import { Children, cloneElement } from '@wordpress/element'; import { __ } from '@wordpress/i18n'; +import { displayShortcut } from '@wordpress/keycodes'; import { store as keyboardShortcutsStore, __unstableUseShortcutEventMatch, @@ -40,7 +41,11 @@ function CopyMenuItem( { clientIds, onCopy, label } ) { onCopy ); const copyMenuItemLabel = label ? label : __( 'Copy' ); - return { copyMenuItemLabel }; + return ( + + { copyMenuItemLabel } + + ); } export function BlockSettingsDropdown( { From e97af0318706655c948475ddf1b6b25abb104b15 Mon Sep 17 00:00:00 2001 From: jasmussen Date: Tue, 2 Apr 2024 11:00:03 +0200 Subject: [PATCH 2/2] Add shortcut to only the main copy item. --- .../block-settings-menu/block-settings-dropdown.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js b/packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js index 35571cf0d7aaa..39e6af2eda511 100644 --- a/packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js +++ b/packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js @@ -34,7 +34,7 @@ const POPOVER_PROPS = { placement: 'bottom-start', }; -function CopyMenuItem( { clientIds, onCopy, label } ) { +function CopyMenuItem( { clientIds, onCopy, label, shortcut } ) { const { getBlocksByClientId } = useSelect( blockEditorStore ); const ref = useCopyToClipboard( () => serialize( getBlocksByClientId( clientIds ) ), @@ -42,7 +42,7 @@ function CopyMenuItem( { clientIds, onCopy, label } ) { ); const copyMenuItemLabel = label ? label : __( 'Copy' ); return ( - + { copyMenuItemLabel } ); @@ -284,6 +284,7 @@ export function BlockSettingsDropdown( { { canDuplicate && (