From 779abbc62d37521b28c3bd65688b8cb0f44398a0 Mon Sep 17 00:00:00 2001 From: George Mamadashvili Date: Thu, 5 May 2022 18:05:52 +0400 Subject: [PATCH 1/2] Code Editor: Fix save shortcut --- packages/edit-post/src/components/text-editor/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/edit-post/src/components/text-editor/index.js b/packages/edit-post/src/components/text-editor/index.js index 47f5d1107d76e..33780c8abbaf5 100644 --- a/packages/edit-post/src/components/text-editor/index.js +++ b/packages/edit-post/src/components/text-editor/index.js @@ -21,6 +21,7 @@ import { store as editPostStore } from '../../store'; function TextEditor( { onExit, isRichEditingEnabled } ) { return (
+ { isRichEditingEnabled && (

{ __( 'Editing code' ) }

@@ -31,7 +32,6 @@ function TextEditor( { onExit, isRichEditingEnabled } ) { > { __( 'Exit code editor' ) } -
) }
From db40e87a8f9c2a9c48912de87258e7554b28dc35 Mon Sep 17 00:00:00 2001 From: George Mamadashvili Date: Thu, 5 May 2022 18:11:49 +0400 Subject: [PATCH 2/2] Refactor to use hooks --- .../src/components/text-editor/index.js | 26 ++++++------------- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/packages/edit-post/src/components/text-editor/index.js b/packages/edit-post/src/components/text-editor/index.js index 33780c8abbaf5..9c9b3c29e9948 100644 --- a/packages/edit-post/src/components/text-editor/index.js +++ b/packages/edit-post/src/components/text-editor/index.js @@ -8,17 +8,21 @@ import { store as editorStore, } from '@wordpress/editor'; import { Button } from '@wordpress/components'; -import { withDispatch, withSelect } from '@wordpress/data'; +import { useDispatch, useSelect } from '@wordpress/data'; import { __ } from '@wordpress/i18n'; import { displayShortcut } from '@wordpress/keycodes'; -import { compose } from '@wordpress/compose'; /** * Internal dependencies */ import { store as editPostStore } from '../../store'; -function TextEditor( { onExit, isRichEditingEnabled } ) { +export default function TextEditor() { + const isRichEditingEnabled = useSelect( ( select ) => { + return select( editorStore ).getEditorSettings().richEditingEnabled; + }, [] ); + const { switchEditorMode } = useDispatch( editPostStore ); + return (
@@ -27,7 +31,7 @@ function TextEditor( { onExit, isRichEditingEnabled } ) {

{ __( 'Editing code' ) }

); } - -export default compose( - withSelect( ( select ) => ( { - isRichEditingEnabled: select( editorStore ).getEditorSettings() - .richEditingEnabled, - } ) ), - withDispatch( ( dispatch ) => { - return { - onExit() { - dispatch( editPostStore ).switchEditorMode( 'visual' ); - }, - }; - } ) -)( TextEditor );