Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons appear warped and/or clipped. #9194

Closed
kjellr opened this issue Aug 21, 2018 · 3 comments
Closed

Icons appear warped and/or clipped. #9194

kjellr opened this issue Aug 21, 2018 · 3 comments
Labels
[Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@kjellr
Copy link
Contributor

kjellr commented Aug 21, 2018

Describe the bug

Some of our icons appear to be a little over-optimized. Their edges are simplified too much, resulting in imbalanced shapes and clipped edges.

I found and cleaned this up in an instance of the Facebook icon (#9178), but I'm realizing now this effects other icons too (see examples below).

Screenshots

Quote Icon

(Ours on left, original Material design icon on the right)
screen shot 2018-08-21 at 8 25 41 am

(Ours in pink, overlaid on the original)
screen shot 2018-08-21 at 8 26 25 am

Gallery Icon

(Ours on left, original Material design icon on the right)
screen shot 2018-08-21 at 8 29 33 am

(Ours in pink, overlaid on the original)
screen shot 2018-08-21 at 8 30 04 am

I can see this occurring on the File, Table, Button, Archives, Latest Comments, SoundCloud, MixCloud, ReverbNation, and Spreaker block icons as well.
@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Type] Question Questions about the design or development of the editor. labels Aug 21, 2018
@mtias
Copy link
Member

mtias commented Aug 21, 2018

These might just need a clean SVG update, I think one of the minifcation tools simplified the shapes and some sneaked in.

@mtias mtias added [Type] Task Issues or PRs that have been broken down into an individual action to take and removed [Type] Bug An existing feature does not function as intended [Type] Question Questions about the design or development of the editor. labels Aug 24, 2018
@ajitbohra
Copy link
Member

@kjellr this seems to be fixed in #13659 except for quote icon.

@kjellr
Copy link
Contributor Author

kjellr commented Feb 25, 2019

Ah, thanks for the ping. I'd forgotten about this issue. 🙂

I'll open a PR with a fix for that quote icon soon.

@kjellr kjellr mentioned this issue Feb 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mtias @ajitbohra @kjellr