Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar "Extended Settings" may be empty when meta boxes are hidden in the Screen Options #6495

Closed
afercia opened this issue Apr 30, 2018 · 1 comment · Fixed by #7570
Closed
Assignees
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Meta Boxes A draggable box shown on the post editing screen

Comments

@afercia
Copy link
Contributor

afercia commented Apr 30, 2018

To reproduce:

  • activate a plugin that adds a meta box in the sidebar
  • in the Classic editor, go to the Screen Options and uncheck the related checkbox to hide the meta box
  • go in Gutenbreg
  • in the sidebar, there's the "Extended Settings" panel
  • click on it to expand it: it's empty

So when all the sidebar meta boxes are "unchecked" in the Screen Options, the "Extended Settings" panel is still rendered. Ideally, it should check if there's at least one "visible" meta box.

Note: "unchecked" meta boxes are hidden with the hide-if-js CSS class.

@afercia afercia added the [Feature] Meta Boxes A draggable box shown on the post editing screen label Apr 30, 2018
@danielbachhuber danielbachhuber added the Backwards Compatibility Issues or PRs that impact backwards compatability label Jun 4, 2018
@danielbachhuber
Copy link
Member

Related #5841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Meta Boxes A draggable box shown on the post editing screen
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants