Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormTokenField: Suggestion should be an array of TokenItem datatype instead of an array of string #63165

Open
SH4LIN opened this issue Jul 5, 2024 · 1 comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.

Comments

@SH4LIN
Copy link

SH4LIN commented Jul 5, 2024

What problem does this address?

  • In the Suggestion box we are only allowed to add an array of strings The problem with that is it doesn't allow to provide slug/key a unique value to identify which item is added to the list.
  • TokenItem is returned in the onChange event but the suggestion should also allow an array of TokenItem.

What is your proposed solution?

  • Change the Suggestion Data type from array of string to array of TokenItem.
@SH4LIN SH4LIN added the [Type] Enhancement A suggestion for improvement. label Jul 5, 2024
@SH4LIN SH4LIN changed the title Suggestion should be array of TokenItem FormTokenField: Suggestion should be an array of TokenItem datatype instead of an array of string Jul 5, 2024
@Mamaduka Mamaduka added the [Feature] UI Components Impacts or related to the UI component system label Jul 5, 2024
@mirka
Copy link
Member

mirka commented Jul 8, 2024

Thanks for posting an issue!

We've received two similar requests/reports in the past:

Do the discussions in those threads provide sufficient reasoning for why we don't really need it to be an array of objects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants