-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra scrollbar appears while editing patterns/template parts whenever there are notices #62911
Comments
I was not able to reproduce this issue, maybe it was fixed in a recent commit? Or do I need some special content? c23ac1eceebc14d462ee42ab497ef135.mp4 |
@t-hamano Interesting, seems like your canvas area didn't get pushed down far enough. Does it still look ok if you add multiple notices? |
Testing at 55f3a98, I was able to reproduce but only in the Post editor. |
I see! I'm sure that was broken before. The site editor behaves closer to how I would expect it to work in the post editor, so hopefully there's a clue there for fixing it. |
One difference between the editors I've noted are these styles applied to the VisualEditor only in the Post Editor: gutenberg/packages/edit-post/src/components/layout/style.scss Lines 1 to 4 in 55f3a98
I found them to be creating a related issue with too many scrollbars for device previews and made #62940 for that. I just tried reproducing this issue on that branch and could not. I'd appreciate any testing or reviews on that 🙇 |
@stokesman Thanks - I've approved that PR. |
Description
When editing patterns any notices result in a second scrollbar appearing.
The bug happens because the notices push the editor canvas area off-screen, which triggers a scrollbar.
I'm personally unsure of the right fix. For the normal post editing experience, the editor canvas shrinks when there's a notice, so perhaps the focus mode should do the same?
Step-by-step reproduction instructions
Observe two scrollbars
Screenshots, screen recording, code snippet
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: