You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
talldan opened this issue
Jan 4, 2024
· 0 comments
Labels
[Feature] PatternsA collection of blocks that can be synced (previously reusable blocks) or unsynced[Type] Code QualityIssues or PRs that relate to code quality
After the rename of Reusable Blocks to Patterns in the UI, there's now quite a bit of technical debt in the codebase.
Some newer features have adopted the 'Patterns' naming within code, while older features still use the 'Reusable Blocks' terminology.
This includes:
A 'reusable blocks' package, which coexists alongside a 'patterns' package.
Comments across the codebase referring to the feature as reusable blocks.
Private and public APIs using the Reusable Blocks naming.
What is your proposed solution?
Private APIs can be renamed.
I think it's worth assessing on a case-by-case basis whether public APIs should be deprecated/renamed to patterns. Or alternatively there may be betters way to achieve what the API does.
In some cases, like the 'reusable blocks' package, it's continued existence might be confusing for developers. That package also seems to have some unused functionality (the redux store), and other than that it only exports one component, so it might be a good option to move functionality over to the patterns package and deprecate the package.
The text was updated successfully, but these errors were encountered:
[Feature] PatternsA collection of blocks that can be synced (previously reusable blocks) or unsynced[Type] Code QualityIssues or PRs that relate to code quality
What problem does this address?
After the rename of Reusable Blocks to Patterns in the UI, there's now quite a bit of technical debt in the codebase.
Some newer features have adopted the 'Patterns' naming within code, while older features still use the 'Reusable Blocks' terminology.
This includes:
What is your proposed solution?
Private APIs can be renamed.
I think it's worth assessing on a case-by-case basis whether public APIs should be deprecated/renamed to patterns. Or alternatively there may be betters way to achieve what the API does.
In some cases, like the 'reusable blocks' package, it's continued existence might be confusing for developers. That package also seems to have some unused functionality (the redux store), and other than that it only exports one component, so it might be a good option to move functionality over to the patterns package and deprecate the package.
The text was updated successfully, but these errors were encountered: