Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky Test] should clear selection when clicking next to blocks #47279

Closed
github-actions bot opened this issue Jan 19, 2023 · 3 comments · Fixed by #48035
Closed

[Flaky Test] should clear selection when clicking next to blocks #47279

github-actions bot opened this issue Jan 19, 2023 · 3 comments · Fixed by #48035
Labels
[Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Jan 19, 2023 •
edited
Loading

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

should clear selection when clicking next to blocks

Test path

/test/e2e/specs/editor/various/multi-block-selection.spec.js

Errors

[2023-01-19T10:27:21.706Z] Test passed after 2 failed attempts on update/use-select-resubscribe.
[2023-01-20T11:43:47.679Z] Test passed after 2 failed attempts on update/use-select-resubscribe.
[2023-03-30T10:48:12.983Z] Test passed after 1 failed attempt on try/footnotes-again.
[2023-04-05T16:02:03.995Z] Test passed after 1 failed attempt on try/block-tools-marry-document-tools.
[2023-06-22T17:29:14.316Z] Test passed after 1 failed attempt on try/perf-entity-prop.
[2023-07-21T12:58:18.788Z] Test passed after 1 failed attempt on feat/async-block-loading.
[2023-08-29T11:52:49.119Z] Test passed after 1 failed attempt on update/make-shortcuts-provider-optional.
[2023-10-25T10:49:44.311Z] Test passed after 1 failed attempt on try/block-edit-lazy-loading.
[2023-11-11T00:16:41.440Z] Test passed after 1 failed attempt on trunk.
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Jan 19, 2023
@github-actions github-actions bot mentioned this issue Jan 19, 2023
Merged
@github-actions
Copy link
Author

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Feb 20, 2023
@kevin940726 kevin940726 mentioned this issue Feb 21, 2023
Merged
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2023
@github-actions github-actions bot reopened this Mar 30, 2023
@github-actions github-actions bot mentioned this issue Mar 30, 2023
Closed
@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Mar 31, 2023
@github-actions github-actions bot mentioned this issue Apr 5, 2023
Closed
@github-actions github-actions bot reopened this Jun 22, 2023
@github-actions github-actions bot mentioned this issue Jun 22, 2023
Closed
@github-actions github-actions bot mentioned this issue Jul 21, 2023
Draft
@github-actions
Copy link
Author

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Aug 25, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2023
@github-actions github-actions bot reopened this Aug 29, 2023
@github-actions github-actions bot mentioned this issue Aug 29, 2023
Closed
@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Aug 31, 2023
@github-actions
Copy link
Author

github-actions bot commented Oct 9, 2023

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Oct 9, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2023
@github-actions github-actions bot reopened this Oct 25, 2023
@github-actions github-actions bot mentioned this issue Oct 25, 2023
Draft
@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Nov 2, 2023
github-actions bot referenced this issue Nov 11, 2023
@jeryj @ajlende @draganescu
Render Selected Block Tools in Header when using Top Toolbar (#55787)
a1ccf42 
The Top Toolbar was relying on position: absolute; CSS and layoutEffect calculations to display the selected block tools visually within the top toolbar. This PR places it in the header DOM where we want it, allowing us to use native CSS and DOM flow to improve accessibility (tab order matches visual order) and have more maintainable code.

* Imports `<BlockContextualToolbar />` via private-api and the <Popover /> for image captions to the edit site, edit post, edit widgets, and customize widget headers.
* Removes position: absolute; and layoutEffect block toolbar positioning hacks.
* CSS for the top toolbar to use flex-shrink and overflow-x: hidden; to allow for the block toolbar to fit its current space and scroll to reveal the hidden tools.
* With top toolbar mode, Shift+Tab does not go directly to the toolbar but the first tabstop outside of the editor.

Co-authored-by: Alex Lende <[email protected]>
Co-authored-by: Andrei Draganescu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate multi-block selection E2E tests to Playwright WordPress/gutenberg
2 participants
@Mamaduka @kevin940726