Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add link in the table first column. #4447

Closed
aniljadhavmca opened this issue Jan 13, 2018 · 3 comments
Closed

Unable to add link in the table first column. #4447

aniljadhavmca opened this issue Jan 13, 2018 · 3 comments
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended

Comments

@aniljadhavmca
Copy link

aniljadhavmca commented Jan 13, 2018

Issue Overview

Unable to add link in the table first column. If we add link on the second column text it's work fine.
But for the first column add link seems have z-index issues here is the detail screen recording - https://goo.gl/HWF9gm

Gutenberg version - 2.0.0

Steps to Reproduce (for bugs)

  1. Add Three column table
  2. Add link to the first row's of all three columns
  3. First columns link have some z-index issue

Google Chrome

Screenshots / Video

https://goo.gl/HWF9gm
https://goo.gl/LZUoMc

@joaodfmota
Copy link

joaodfmota commented Jan 15, 2018

This probably is linked to #3941

Remove overflow-x from \blocks\library\table\style.scss work's like a default text block.

capture002

.wp-block-table {
    overflow-x: auto; /* Remove this line */
    display: block;
}

@aniljadhavmca
Copy link
Author

aniljadhavmca commented Jan 15, 2018

@joaodfmota Thanks for the quick reply, second option will looks good. i.e - link box inside the table tr.

I am sending PR for this fix.

@jeffpaul jeffpaul added the [Type] Bug An existing feature does not function as intended label Jan 26, 2018
@noisysocks noisysocks added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable labels Apr 26, 2018
@amychan331
Copy link

It seems like this haven't been work on since January. Can I try this as my first bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

6 participants