Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Editor: Update "Delete template" to "Clear customizations" when appropriate #40885

Closed
jameskoster opened this issue May 6, 2022 · 1 comment · Fixed by #40935
Closed
Assignees
Labels
[Feature] Template Editing Mode Related to the template editor available in the Block Editor [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Related to #40881.

What problem does this address?

If you have customised a theme template, then open that template in the Template Editor, the UI suggests that template can be deleted (and the padding is messed up):

Screenshot 2022-05-06 at 11 44 59

Clicking "Delete template" will clear your customisations but not delete the template.

What is your proposed solution?

Update the label to use the "Clear customizations" language from the Site Editor:

Screenshot 2022-05-06 at 11 48 45

@jameskoster jameskoster added the [Feature] Template Editing Mode Related to the template editor available in the Block Editor label May 6, 2022
@Mamaduka
Copy link
Member

Mamaduka commented May 6, 2022

I think this was mentioned in the original PR as well, but I forgot to do a follow-up.

I will assign this issue to myself and push an update next week.

@Mamaduka Mamaduka added the [Type] Enhancement A suggestion for improvement. label May 6, 2022
@Mamaduka Mamaduka self-assigned this May 6, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 9, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Template Editing Mode Related to the template editor available in the Block Editor [Type] Enhancement A suggestion for improvement.
Projects
None yet
3 participants